Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blame information is invalid when a file has unsaved changes #36

Closed
SailorMax opened this issue Mar 2, 2017 · 4 comments
Closed

Blame information is invalid when a file has unsaved changes #36

SailorMax opened this issue Mar 2, 2017 · 4 comments
Assignees
@eamodio
Labels
bug Something isn't working

Comments

@SailorMax
Copy link

GitLens ignore new line shifts in modified file.

Steps:

  1. open document modify history has few people, for example:
    line 1 by user A
    line 2 by user B
    line 3 by user C
  2. put cursor in end of line 1 and press Enter
  3. check owners of lines 1-4

Expected:
line 1 by user A
line 2 (empty) has no user
line 3 by user B
line 4 by user C

Actual:
line 1 by user A
line 2 (empty) by user B
line 3 by user C
line 4 has no user
@eamodio eamodio added needs-more-info Needs further information, steps, details, etc. bug Something isn't working and removed needs-more-info Needs further information, steps, details, etc. labels Mar 2, 2017
@eamodio eamodio self-assigned this Mar 2, 2017
@eamodio
Copy link
Member

eamodio commented Mar 2, 2017

@SailorMax Thanks for the report -- there are some definitely issues here and will get them fixed up!

@eamodio eamodio changed the title output wrong(shifted) data if add/remove strings Blame information is invalid when a file has unsaved changes Mar 3, 2017
@eamodio eamodio closed this as completed Mar 3, 2017
eamodio added a commit that referenced this issue Mar 3, 2017
@eamodio
Changes behaviors when file has unsaved changes:
1519898 
  - Status bar blame information will hide
  - CodeLens change to a `Cannot determine...` message and become unclickable
  - Many menu choices and commands will hide
Fixes #36 - Blame information is invalid when a file has unsaved changes
Fixed #38 - Toggle Blame Annotation button shows even when it isn't valid
Preps v2.9.0
@SailorMax
Copy link
Author

@eamodio Same problem still exist if file was modified by external editor. VSCode catch modifications, but GitLens - not.

@eamodio
Copy link
Member

eamodio commented May 5, 2017

@SailorMax can you open a separate issue for that? Also please provide the steps to reproduce it. Thanks!

@SailorMax SailorMax mentioned this issue May 5, 2017
Closed
billsedison added a commit to noside911/vscode-gitlens that referenced this issue Jan 4, 2019
@billsedison
Merge pull request gitkraken#36 from mfikria/tc-dev
ede85f6 
Implement show merge commits option gitkraken#28
@snyk-bot snyk-bot mentioned this issue Mar 10, 2020
Open
@github-actions
Copy link

github-actions bot commented Dec 8, 2020

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@eamodio eamodio

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eamodio @SailorMax