Reworks git commands a bit to reduce rethrows

Fixes #405 - stops non-repo from showing up in explorer

CHANGELOG.md

@@ -12,6 +12,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/) and this p
 
 ### Fixed
 
+- Fixes [#405](https://github.com/eamodio/vscode-gitlens/issues/405) - Secondary, blank repository appears repeatedly in gitExplorer view
 - Fixes issues with git log caching
 
 ### Removed

src/annotations/gutterBlameAnnotationProvider.ts

@@ -142,8 +142,7 @@ export class GutterBlameAnnotationProvider extends BlameAnnotationProviderBase {
             }
         }
 
-        const duration = process.hrtime(start);
-        Logger.log(`${duration[0] * 1000 + Math.floor(duration[1] / 1000000)} ms to compute gutter blame annotations`);
+        Logger.log(`${Strings.getDurationMilliseconds(start)} ms to compute gutter blame annotations`);
 
         this.registerHoverProviders(Container.config.hovers.annotations);
         void this.selection(shaOrLine, blame);

src/annotations/heatmapBlameAnnotationProvider.ts

@@ -4,6 +4,7 @@ import { FileAnnotationType } from '../configuration';
 import { Container } from '../container';
 import { GitBlameCommit } from '../gitService';
 import { Logger } from '../logger';
+import { Strings } from '../system';
 import { Annotations } from './annotations';
 import { BlameAnnotationProviderBase } from './blameAnnotationProvider';
 
@@ -55,8 +56,7 @@ export class HeatmapBlameAnnotationProvider extends BlameAnnotationProviderBase
             this.editor.setDecorations(this.decoration!, this.decorations);
         }
 
-        const duration = process.hrtime(start);
-        Logger.log(`${duration[0] * 1000 + Math.floor(duration[1] / 1000000)} ms to compute heatmap annotations`);
+        Logger.log(`${Strings.getDurationMilliseconds(start)} ms to compute heatmap annotations`);
 
         this.registerHoverProviders(Container.config.hovers.annotations);
         void this.selection(shaOrLine, blame);

src/annotations/recentChangesAnnotationProvider.ts

@@ -4,6 +4,7 @@ import { FileAnnotationType } from '../configuration';
 import { Container } from '../container';
 import { GitUri } from '../gitService';
 import { Logger } from '../logger';
+import { Strings } from '../system';
 import { GitDocumentState, TrackedDocument } from '../trackers/gitDocumentTracker';
 import { AnnotationProviderBase } from './annotationProvider';
 import { Annotations } from './annotations';
@@ -82,10 +83,7 @@ export class RecentChangesAnnotationProvider extends AnnotationProviderBase {
 
         this.editor.setDecorations(this.decoration, this.decorations);
 
-        const duration = process.hrtime(start);
-        Logger.log(
-            `${duration[0] * 1000 + Math.floor(duration[1] / 1000000)} ms to compute recent changes annotations`
-        );
+        Logger.log(`${Strings.getDurationMilliseconds(start)} ms to compute recent changes annotations`);
 
         return true;
     }

src/extension.ts

@@ -13,12 +13,12 @@ import {
     KeyMap,
     OutputLevel
 } from './configuration';
-import { CommandContext, extensionQualifiedId, GlobalState, setCommandContext } from './constants';
+import { CommandContext, extensionQualifiedId, GlobalState, GlyphChars, setCommandContext } from './constants';
 import { Container } from './container';
 import { GitService } from './gitService';
 import { Logger } from './logger';
 import { Messages } from './messages';
-import { Versions } from './system';
+import { Strings, Versions } from './system';
 // import { Telemetry } from './telemetry';
 
 export async function activate(context: ExtensionContext) {
@@ -83,8 +83,7 @@ export async function activate(context: ExtensionContext) {
     // Constantly over my data cap so stop collecting initialized event
     // Telemetry.trackEvent('initialized', Objects.flatten(cfg, 'config', true));
 
-    const duration = process.hrtime(start);
-    Logger.log(`GitLens(v${gitlensVersion}) activated in ${duration[0] * 1000 + Math.floor(duration[1] / 1000000)} ms`);
+    Logger.log(`GitLens(v${gitlensVersion}) activated ${GlyphChars.Dot} ${Strings.getDurationMilliseconds(start)} ms`);
 }
 
 export function deactivate() {}