feat(settings): ignore bot notifications #929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setchy
added
the
enhancement
…/gitify-app/gitify into feature/ignore-bot-notifications
bmulholland
reviewed
Mar 27, 2024
| const isEnterprise = isEnterpriseHost( | ||
| accountNotifications.hostname, | ||
| ); | ||
| const token = isEnterprise |
Collaborator
There was a problem hiding this comment.
IMHO this indentation level has crossed a line where something should be split into smaller pieces.
Member
Author
There was a problem hiding this comment.
Agree - I too would really like to refactor most of this file into smaller pieces.
bmulholland
approved these changes
Mar 27, 2024
Collaborator
bmulholland
left a comment
bmulholland
left a comment
There was a problem hiding this comment.
Looks good, just the concern about nested complexity in useNotifications
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add setting to control whether notification from
Botaccounts are shown or hidden.Closes #591