fix: remove notification from state on open #789
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adufr
requested review from
afonsojramos,
bmulholland and
setchy
as code owners
setchy
previously approved these changes
Feb 18, 2024
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
Author
|
Coverage has now increased 🚀 |
setchy
approved these changes
Feb 18, 2024
bmulholland
reviewed
Feb 19, 2024
| if (settings.markAsDoneOnOpen) { | ||
| markNotificationDone(notification.id, hostname); | ||
| } else { | ||
| // no need to mark as read, github does it by default when opening it |
Collaborator
There was a problem hiding this comment.
Thanks for the explanation!
adufr
added a commit
to adufr/gitify
that referenced
this pull request
Feb 19, 2024
* fix: remove notification from state on open * tests: add test for `removeNotificationFromState`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Context
Remove notification from state when clicking on it.