Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(refactor): Simplify window re-open #651

Merged
merged 10 commits into from
Oct 9, 2023

Conversation

bmulholland
Copy link
Collaborator

No description provided.

Base automatically changed from 10-03-chore_electron_Move_off_deprecated_remote_module to main October 9, 2023 23:37
Copy link
Member

@afonsojramos afonsojramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose that we don't really need to abstract this. LGTM

@afonsojramos
Copy link
Member

Not sure why this PR is part of the stack though, I assume just out of convenience?

@afonsojramos afonsojramos merged commit ede8030 into main Oct 9, 2023
6 checks passed
@afonsojramos afonsojramos deleted the 10-04-chore_refactor_Simplify_window_re-open branch October 9, 2023 23:54
@bmulholland
Copy link
Collaborator Author

Yeah, I think I was just in context and defaulted to adding to the stack

@setchy setchy added the refactor Refactoring of existing feature label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactoring of existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants