Skip to content

fix: notification appId for windows #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
afonsojramos merged 4 commits into from
May 22, 2023
Merged

fix: notification appId for windows #539

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
75d3149
fix notification appId
Araxeus Mar 8, 2022
8869d69
Platform specific native notification title
Araxeus Mar 28, 2022
c90f322
Merge branch 'main' into fix-notification-appId
afonsojramos May 22, 2023
9b9f724
fix: prettier styling
afonsojramos May 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ const { autoUpdater } = require('electron-updater');
const { onFirstRunMaybe } = require('./first-run');
const path = require('path');

app.setAppUserModelId('com.electron.gitify');

const iconIdle = path.join(
__dirname,
'assets',
Expand Down
2 changes: 1 addition & 1 deletion src/utils/notifications.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ export const raiseNativeNotification = (

if (notifications.length === 1) {
const notification = notifications[0];
title = `Gitify - ${notification.repository.full_name}`;
Comment thread
Araxeus marked this conversation as resolved.
title = notification.repository.full_name;
body = notification.subject.title;
notificationUrl = notification.subject.url;
} else {
Expand Down