fix: github enterprise login #533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uanid
changed the title
codebytere
reviewed
Jan 3, 2022
Collaborator
codebytere
left a comment
codebytere
left a comment
There was a problem hiding this comment.
Minor nit, otherwise good to go.
codebytere
approved these changes
Jan 3, 2022
|
Thank you @uanid for fixing this and @codebytere for reviewing this 🙂 . Do we know whose approval from maintainers do we need here ? |
uanid
changed the title
Contributor
|
@pbsureja want to make the same PR in my fork? 🙂 https://github.com/Araxeus/gitify |
afonsojramos
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I saw #524, Also I tested with latest commits.
But Login to Github Enterprise Server with PAT not works. (See #527)
Because Github Etnerprise Server's API url pattern is
https://${hostname}/api/v3.Changes
This PR deduplicates api-url generate codes.
Github Enterprise API url reference
https://docs.github.com/en/[email protected]/rest/reference/users
