Skip to content

fix: discussions url #1582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
setchy merged 3 commits into from
Oct 11, 2024
Merged

fix: discussions url #1582

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eea0ee5
fix: discussions url
setchy Oct 10, 2024
0a2cc8e
fix: discussions url lookup
setchy Oct 10, 2024
56021f9
docs: add reference to open issue
setchy Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/renderer/utils/helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,13 @@ export async function generateGitHubWebUrl(
): Promise<Link> {
const url = new URL(notification.repository.html_url);

// FIXME upstream GitHub API has started returning subject urls for Discussion notification types,
// however these URLs are broken. Temporarily downgrading to use discussion lookup process.
if (notification.subject.type === 'Discussion') {
notification.subject.url = null;
notification.subject.latest_comment_url = null;
}

try {
if (notification.subject.latest_comment_url) {
url.href = await getHtmlUrl(
Expand Down