Make install script executable #8
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without it being executable the install instructions fail. `sudo: ./util/install_macos.sh: command not found`
|
The instructions don't use sudo... Lines 50 to 52 in 421b5a8 What's more, the install script works in your home folder, so sudo isn't required. |
Author
|
Fair points. I will argue though that by having a #! as a first line of the file including the interpreter to use, the install directions can be simplified to just |
Closed
Contributor
|
Fixed in 8847e6c |
Contributor
|
Thank you for the PR, it's appreciated! Was fixed while I was doing a pass on the installation issues, this is not a rejection 💞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without it being executable the install instructions fail.
sudo: ./util/install_macos.sh: command not found