Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump eslint-plugin-github from 4.8.0 to 4.9.2 #456

Merged
merged 2 commits into from
Jul 19, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 19, 2023

Bumps eslint-plugin-github from 4.8.0 to 4.9.2.

Release notes

Sourced from eslint-plugin-github's releases.

v4.9.2

What's Changed

Full Changelog: github/eslint-plugin-github@v4.9.1...v4.9.2

v4.9.1

Bug fixes

This release includes bug fixes for a few accessibility rules including: a11y-aria-role-supports-props, a11y-no-title-attribute, and jsx-a11y/no-interactive-element-to-noninteractive-role.

What's Changed

New Contributors

Full Changelog: github/eslint-plugin-github@v4.9.0...v4.9.1

v4.9.0

What's Changed

New Contributors

Full Changelog: github/eslint-plugin-github@v4.8.0...v4.9.0

Commits
  • cd17c09 Merge pull request #466 from github/kh-use-literal-prop-for-class
  • c2ea115 Use literal prop
  • dd3cba1 Add failing test case
  • 0c0441f Merge pull request #463 from github/kh-use-prop-value
  • 8c5f809 Merge branch 'main' into kh-use-prop-value
  • 125ac51 Merge pull request #464 from github/fix-a11y-no-title-attribute
  • ee9e16d lint
  • 29ead03 add test
  • b05b0cb Do not look up as prop
  • 7036141 Add logic to check for presence of attribute
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Jul 19, 2023
@dependabot dependabot bot requested a review from a team as a code owner July 19, 2023 02:54
@github-actions
Copy link

github-actions bot commented Jul 19, 2023

Bundle Stats - With chunk and module information

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
2 1.98 MB 0%
Changeset
File Δ Size
src/client/this/file/has/a/long/name/so-that-it-will-hopefully-wrap.tsx 🆕 +2.72 KB 0 B -> 2.72 KB
src/client/this-file-was-added.ts 🆕 +1.46 KB 0 B -> 1.46 KB
src/client/this-is-another-file-with-a-long-name-to-test-the-table-sizing.tsx 🆕 +1.04 KB 0 B -> 1.04 KB
src/client/helpers/this-file-is-much-larger.ts 📈 +11.66 KB (+865.77%) 1.35 KB -> 13.01 KB
src/client/this-file-grew-larger.tsx 📈 +200 B (+35.59%) 562 B -> 762 B
src/client/helpers/this-file-grew-smaller.ts 📉 -200 B (-7.94%) 2.46 KB -> 2.26 KB
src/client/this-file-is-much-smaller.tsx 📉 -11.66 KB (-99.92%) 11.67 KB -> 10 B
src/client/routes.tsx 🔥 -2.72 KB (-100%) 2.72 KB -> 0 B
src/client/this-file-will-be-deleted.ts 🔥 -1.46 KB (-100%) 1.46 KB -> 0 B
src/client/render-memex.tsx 🔥 -1.04 KB (-100%) 1.04 KB -> 0 B
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
app.bundle.js 1.98 MB 0%
manifest.json 91 B 0%

@github-actions
Copy link

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
7 -> 2 1.34 MB -> 1.29 MB (-53.65 KB)
386.44 KB -> N/A (gzip)
-3.91%
View detailed bundle breakdown

Added

No assets were added

Removed

Asset File Size % Changed
296.chunk.js 124.57 KB -> 0 B (-124.57 KB)
35.05 KB -> 0 B (gzip)
-100%
288.chunk.js 57.24 KB -> 0 B (-57.24 KB)
16.33 KB -> 0 B (gzip)
-100%
920.chunk.js 54.98 KB -> 0 B (-54.98 KB)
17.08 KB -> 0 B (gzip)
-100%
912.chunk.js 44.37 KB -> 0 B (-44.37 KB)
14.31 KB -> 0 B (gzip)
-100%
699.chunk.js 26.39 KB -> 0 B (-26.39 KB)
6.14 KB -> 0 B (gzip)
-100%

Bigger

Asset File Size % Changed
app.bundle.js 1.04 MB -> 1.29 MB (+254.35 KB)
297.38 KB -> N/A (gzip)
+23.91%

Smaller

Asset File Size % Changed
manifest.json 551 B -> 91 B (-460 B)
151 B -> N/A (gzip)
-83.48%

Unchanged

No assets were unchanged

@github-actions
Copy link

Bundle Stats - Flipped around

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
2 -> 7 1.29 MB -> 1.34 MB (+53.65 KB)
N/A -> 386.44 KB (gzip)
+4.07%
View detailed bundle breakdown

Added

Asset File Size % Changed
296.chunk.js 0 B -> 124.57 KB (+124.57 KB)
0 B -> 35.05 KB (gzip)
-
288.chunk.js 0 B -> 57.24 KB (+57.24 KB)
0 B -> 16.33 KB (gzip)
-
920.chunk.js 0 B -> 54.98 KB (+54.98 KB)
0 B -> 17.08 KB (gzip)
-
912.chunk.js 0 B -> 44.37 KB (+44.37 KB)
0 B -> 14.31 KB (gzip)
-
699.chunk.js 0 B -> 26.39 KB (+26.39 KB)
0 B -> 6.14 KB (gzip)
-

Removed

No assets were removed

Bigger

Asset File Size % Changed
manifest.json 91 B -> 551 B (+460 B)
N/A -> 151 B (gzip)
+505.49%

Smaller

Asset File Size % Changed
app.bundle.js 1.29 MB -> 1.04 MB (-254.35 KB)
N/A -> 297.38 KB (gzip)
-19.29%

Unchanged

No assets were unchanged

@github-actions
Copy link

Bundle Stats - Non existent

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
0 0 B 0%
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

No assets were unchanged

@github-actions
Copy link

Bundle Stats - No changes

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
7 1.34 MB
386.44 KB
0%
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
app.bundle.js 1.04 MB
297.38 KB
0%
296.chunk.js 124.57 KB
35.05 KB
0%
288.chunk.js 57.24 KB
16.33 KB
0%
920.chunk.js 54.98 KB
17.08 KB
0%
912.chunk.js 44.37 KB
14.31 KB
0%
699.chunk.js 26.39 KB
6.14 KB
0%
manifest.json 551 B
151 B
0%

Copy link
Member

@shiftkey shiftkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Investigating new CI failures

Bumps [eslint-plugin-github](https://github.com/github/eslint-plugin-github) from 4.8.0 to 4.9.2.
- [Release notes](https://github.com/github/eslint-plugin-github/releases)
- [Commits](github/eslint-plugin-github@v4.8.0...v4.9.2)

---
updated-dependencies:
- dependency-name: eslint-plugin-github
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/eslint-plugin-github-4.9.2 branch from 8b513f0 to ea7bacc Compare July 19, 2023 12:28
"eslint-plugin-jest": "^27.2.3",
"eslint-plugin-prettier": "^5.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This dependency is now required (probably because the eslint-plugin-github config includes prettier/prettier).

"jest": "^29.6.1",
"js-yaml": "^4.1.0",
"prettier": "^2.8.8",
"prettier": "^3.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because eslint-plugin-github now uses prettier@v3 we also need to be on this version...

@shiftkey shiftkey added this pull request to the merge queue Jul 19, 2023
Merged via the queue into main with commit 91bd2bc Jul 19, 2023
@shiftkey shiftkey deleted the dependabot/npm_and_yarn/eslint-plugin-github-4.9.2 branch July 19, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant