all config settings need to start global #311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as our first time working through some commands, we can't just set the options without a flag. If we were already in a repository, this would work but we wont get to that until further into the class.
Good catch! I'm 🆒 with that. Let's update the extended descriptions of |
|
@jordanmccullough thanks for the heads up! |
brntbeer
added a commit
that referenced
this pull request
Feb 17, 2015
all config settings need to start global
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as our first time working through some commands,
we can't just set the options without a flag. If
we were already in a repository, this would work
but we wont get to that until further into the
class.
cc @jordanmccullough for review.
This addresses #307