Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up variable names, remove broken objects, prettify queries, add pagination example #686

Merged
merged 3 commits into from
Oct 25, 2023

Conversation

sn2b
Copy link
Contributor

@sn2b sn2b commented Oct 13, 2023

Following the addition of some new queries, I tried to standardize them a little bit. This includes the following:

  • Using standard variable and value names (camelcase for variables like orgName, uppercase for value placeholders like ORG_NAME)
  • Making sure every query starts with query {
  • Renaming graphql/queries/10-mutation-issue-comment-get-issue.graphql to reflect that it is a query, not a mutation
  • Adding a query that demonstrates pagination with the gh cli

Let me know if you are not happy with these changes. Happy to discuss!

@sn2b sn2b marked this pull request as ready for review October 13, 2023 12:49
@sn2b sn2b merged commit 7916085 into master Oct 25, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants