-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating the GraphQL queries for enterprise and org member data (saml identities, scim identities, emails for EMUs) #683
Conversation
…-member-saml-linked-identities.graphql
…s-with-scim-identity-org.graphql
…th-scim-identity-enterprise.graphql
…-saml-linked-identities.graphql
…scim-linked-identities.graphql
…ions-in-enterprise-scim-identities.graphql
…e-organization-scim-linked-identities.graphql
…identities-single-organization.graphql
…m-identities-all-orgs-in-enterprise.graphql
…nterprise-level.graphql
…ise-member-email-addresses.graphql
Hi @stacycarter 👋🏻 The queries all seem to work fine. I just have a couple of "cleanup" points. I don't know if there is a best practice or skeleton to use for this repo, but I'd like to point out a couple things:
Let me know if you want to chat about this. I am also open to hear other opinions. Like I said, the queries work and I'd be happy to approve this either way, I just thought I'd mention it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just saw your comment in the #support-squad-ecosystem Slack thread about adding pagination later! Sorry I missed that earlier.
Thanks for the review and the helpful comments @sn2b! ❤️ I completely agree - I think the queries need to be cleaned up and made more consistent. I'm thinking what we could do is merge the changes we have in this PR, and then as time allows, a new PR could be opened to make the improvements that you mentioned above. |
This PR is to update various GraphQL queries for listing enterprise or organization member details such as SAML identities, SCIM identities, enterprise member email addresses (emails for EMU enterprises specifically), and other details.
The query that should be used from this list and the output that is returned will depend on both the type of GitHub Enterprise Cloud enterprise (EMU or non-EMU), and the type of authentication/SCIM configuration that is in place.
List of queries being added/updated:
List of query files being removed (for cleanup and to avoid duplication since the queries above should take are of it)