-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert jekyll-relative-links to 0.6.1 and add a test #910
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunate, but a good compromise.
I started working on another fix to Jekyll for this but didn't get to passing tests. jekyll/jekyll#9552 |
@parkr I am happy to hold. But either way is fine with me. I don't think it's a big issue to revert |
@yoannchaudet Please revert for now! Then we can test the Jekyll update together with this plugin update once it's more ready. |
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github-pages](https://github.com/github/pages-gem) | `"~> 230"` -> `"~> 231"` | [![age](https://developer.mend.io/api/mc/badges/age/rubygems/github-pages/231?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/rubygems/github-pages/231?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/rubygems/github-pages/230/231?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/rubygems/github-pages/230/231?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>github/pages-gem (github-pages)</summary> ### [`v231`](https://github.com/github/pages-gem/releases/tag/v231) [Compare Source](https://github.com/github/pages-gem/compare/v230...v231) #### What's Changed - Revert jekyll-relative-links to 0.6.1 and add a test by [@​yoannchaudet](https://github.com/yoannchaudet) in [https://github.com/github/pages-gem/pull/910](https://github.com/github/pages-gem/pull/910) **Full Changelog**: github/pages-gem@v230...v231 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 6am on monday" in timezone Australia/Sydney, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/google/osv-scanner). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMTIuMCIsInVwZGF0ZWRJblZlciI6IjM3LjIxMi4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github-pages](https://github.com/github/pages-gem) | `"~> 228"` -> `"~> 231"` | [![age](https://developer.mend.io/api/mc/badges/age/rubygems/github-pages/231?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/rubygems/github-pages/231?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/rubygems/github-pages/228/231?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/rubygems/github-pages/228/231?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>github/pages-gem (github-pages)</summary> ### [`v231`](https://github.com/github/pages-gem/releases/tag/v231) [Compare Source](https://github.com/github/pages-gem/compare/v230...v231) #### What's Changed - Revert jekyll-relative-links to 0.6.1 and add a test by [@​yoannchaudet](https://github.com/yoannchaudet) in [https://github.com/github/pages-gem/pull/910](https://github.com/github/pages-gem/pull/910) **Full Changelog**: github/pages-gem@v230...v231 ### [`v230`](https://github.com/github/pages-gem/releases/tag/v230) [Compare Source](https://github.com/github/pages-gem/compare/v229...v230) #### What's Changed - Bump docker/login-action from 2 to 3 by [@​dependabot](https://github.com/dependabot) in [https://github.com/github/pages-gem/pull/907](https://github.com/github/pages-gem/pull/907) - Bump docker/build-push-action from 4 to 5 by [@​dependabot](https://github.com/dependabot) in [https://github.com/github/pages-gem/pull/905](https://github.com/github/pages-gem/pull/905) - Bump docker/setup-buildx-action from 2 to 3 by [@​dependabot](https://github.com/dependabot) in [https://github.com/github/pages-gem/pull/906](https://github.com/github/pages-gem/pull/906) - Bump Jekyll to 3.9.5 by [@​yoannchaudet](https://github.com/yoannchaudet) in [https://github.com/github/pages-gem/pull/908](https://github.com/github/pages-gem/pull/908) **Full Changelog**: github/pages-gem@v229...v230 ### [`v229`](https://github.com/github/pages-gem/releases/tag/v229) [Compare Source](https://github.com/github/pages-gem/compare/v228...v229) #### What's Changed - Bump docker/metadata-action from 4 to 5 by [@​dependabot](https://github.com/dependabot) in [https://github.com/github/pages-gem/pull/889](https://github.com/github/pages-gem/pull/889) - Bump actions/checkout from 3 to 4 by [@​dependabot](https://github.com/dependabot) in [https://github.com/github/pages-gem/pull/888](https://github.com/github/pages-gem/pull/888) - Fixes `$github-pages health-check` NoMethodError by [@​edward](https://github.com/edward) in [https://github.com/github/pages-gem/pull/878](https://github.com/github/pages-gem/pull/878) - Support Ruby 3.2+, fixes [#​879](https://github.com/github/pages-gem/issues/879) by [@​fulldecent](https://github.com/fulldecent) in [https://github.com/github/pages-gem/pull/880](https://github.com/github/pages-gem/pull/880) - Create publish-gem.yml by [@​tsusdere](https://github.com/tsusdere) in [https://github.com/github/pages-gem/pull/898](https://github.com/github/pages-gem/pull/898) - Bump actions/checkout from 3 to 4 by [@​dependabot](https://github.com/dependabot) in [https://github.com/github/pages-gem/pull/900](https://github.com/github/pages-gem/pull/900) - Enable multi arch docker image build by [@​rngtng](https://github.com/rngtng) in [https://github.com/github/pages-gem/pull/884](https://github.com/github/pages-gem/pull/884) - Bring back proper support for Ruby 3.x by [@​yoannchaudet](https://github.com/yoannchaudet) in [https://github.com/github/pages-gem/pull/901](https://github.com/github/pages-gem/pull/901) - Bump dependencies (patch and minor only) by [@​yoannchaudet](https://github.com/yoannchaudet) in [https://github.com/github/pages-gem/pull/902](https://github.com/github/pages-gem/pull/902) - Fix release script by [@​yoannchaudet](https://github.com/yoannchaudet) in [https://github.com/github/pages-gem/pull/903](https://github.com/github/pages-gem/pull/903) - Another publish script fix by [@​yoannchaudet](https://github.com/yoannchaudet) in [https://github.com/github/pages-gem/pull/904](https://github.com/github/pages-gem/pull/904) #### New Contributors - [@​edward](https://github.com/edward) made their first contribution in [https://github.com/github/pages-gem/pull/878](https://github.com/github/pages-gem/pull/878) - [@​fulldecent](https://github.com/fulldecent) made their first contribution in [https://github.com/github/pages-gem/pull/880](https://github.com/github/pages-gem/pull/880) - [@​tsusdere](https://github.com/tsusdere) made their first contribution in [https://github.com/github/pages-gem/pull/898](https://github.com/github/pages-gem/pull/898) - [@​rngtng](https://github.com/rngtng) made their first contribution in [https://github.com/github/pages-gem/pull/884](https://github.com/github/pages-gem/pull/884) **Full Changelog**: github/pages-gem@v228...v229 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/trussworks/research-design-playbook). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNzMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE3My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Prep release 231.
It rolls back jekyll-relative-links to 0.6.1 and while at it, add a test for front matter based excerpt which stopped working for some reasons.
Related jekyll/jekyll#9544