-
Couldn't load subscription status.
- Fork 357
Create publish-gem.yml #898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
f3ee583
bb1d50e
ecb7a8a
31bce95
2d66a27
351e4a7
8c97daf
7337649
549fa79
d7615e1
a1e407c
3980c1a
90b989b
7c86cdb
d73437f
9ccadb7
8dd7a80
48da3d2
460897f
798d778
fa1b540
117fd75
ed0d437
91e261d
c31c982
47322fd
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| name: Publish Gem | ||
|
|
||
| on: | ||
| release: | ||
| types: [released] | ||
|
|
||
| jobs: | ||
| release: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v3 | ||
| - name: Setup Ruby | ||
| uses: ruby/setup-ruby@v1 | ||
| with: | ||
| ruby-version: "3.3" | ||
| - name: Build gem | ||
| run: | | ||
| gem build github-pages.gemspec | ||
| - name: Publish | ||
| run: | | ||
| gem push github-pages.gem --key ${{ secrets.PAGES_GEM_PUBLISH }} | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 2.7.3 | ||
| 3.3 |
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| FROM ruby:2.7.3-alpine | ||
| FROM ruby:3.3-alpine | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I believe CI is attempting to pass the RUBY_VERSION build arg, but here it's always ruby 3.3. Either remove the RUBY_VERSION arg from CI and script/cibuild-docker or support it here in Dockerfile. |
||
|
|
||
| RUN apk update && apk add --no-cache \ | ||
| git | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,7 +7,7 @@ module GitHubPages | |
| class Dependencies | ||
| VERSIONS = { | ||
| # Jekyll | ||
| "jekyll" => "3.9.3", | ||
| "jekyll" => "3.9.4", | ||
| "jekyll-sass-converter" => "1.5.2", | ||
|
|
||
| # Converters | ||
|
|
@@ -63,7 +63,7 @@ def self.version_report | |
| require "nokogiri" | ||
|
|
||
| { | ||
| "ruby" => RUBY_VERSION, | ||
| "ruby" => "3.3", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This will show unexpected values for non-Ruby 3.3 CI. |
||
|
|
||
| # Gem versions we're curious about | ||
| "github-pages" => VERSION.to_s, | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should only run when merge into master branch or tag release I think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to instead run the job when we merge into
masterbranch?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.