-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Whitelist jekyll-data plugin #610
Comments
I have asked for similar functionality. Either this or just make it part of the solution; it can work just like _includes and other folders where if the pages using the theme override _data/somefile.yml, for instance then the pages one is used instead of the theme one. |
Yep, this would be really useful, e.g. to maintain a consistent navigation menu when a site is built by composing the gh pages of multiple gh repos. Currently, I have to keep data files synchronised across 20 odd repos. A right PITA! ;) |
Related to benbalter/jekyll-remote-theme#68 |
We upstreamed theme data folder propagation to Jekyll: jekyll/jekyll#8815 I believe this repo is in maintenance mode. GitHub Actions now has first-class support for Pages, so I'd recommend setting that up for affected repos if you can. |
Use Jekyll v4.3.0 or later. Full release notes (including the above linked PR): https://github.com/jekyll/jekyll/releases/tag/v4.3.0 |
Thanks!
…On Sat, 12 Nov 2022 at 19:50, Parker Moore ***@***.***> wrote:
Use Jekyll v4.3.0 or later. Full release notes (including the above linked
PR): https://github.com/jekyll/jekyll/releases/tag/v4.3.0
—
Reply to this email directly, view it on GitHub
<#610 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB5EE3QPXRX75DOK4IOMS5LWH7YHJANCNFSM4GLWMQJQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
A bit of Googling on this seems to suggest that this involves switching to a workflow to build the docs, and it may well be the case that the thème I'm using isn't compatible with Jekyll 4.x. I'm a Ruby / Jekyll noob, and the upgrade is daunting. I'm therefore wondering if this whitelisting would enable the required functionally without the need to switch to workflow or finding a Jekyll 4.x theme. Thoughts @parkr ? |
@big-andy-coates The Jekyll v4 upgrade isn't that big actually – the reason I never got around to it while I worked at GitHub was because there was a breaking change in I don't work for GH anymore but from what I gather on their blog, Actions is The Future ™️ so they're likely not accommodating the security review and maintenance of additional plugins at this time. I can't say for sure though, but if I were you, I'd migrate to an (Actions) workflow and have full customizability. :) |
In lieu of a proper translation solution (#401), can we at least make data in themes portable by whitelisting https://github.com/ashmaroli/jekyll-data. Keeping data that belongs to the theme (like common navigation or translation phrases) in sync is really complicated at the moment. This would be a relatively simple solution.
The text was updated successfully, but these errors were encountered: