Test PR for dotnet-analyzers-action #20
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,38 +1,39 @@ | ||
| # sample-workflow-windows-latest | ||
| # docs are in the repo | ||
|
|
||
| name: .NET Analyzers on-push-verification windows-latest | ||
| on: push | ||
|
|
||
| jobs: | ||
| sample: | ||
| name: .NET Analyzers runner | ||
|
|
||
| # .NET Analyzers runs on windows-latest. | ||
| # ubuntu-latest and macos-latest supporting coming soon | ||
| runs-on: windows-latest | ||
|
|
||
| # default working directory to the current directory | ||
| defaults: | ||
| run: | ||
| working-directory: . | ||
|
|
||
mavasani marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| steps: | ||
|
|
||
| # Checkout your code repository to scan | ||
| - uses: actions/checkout@v2 | ||
|
|
||
| # Ensure a compatible version of dotnet is installed. | ||
| # The [Microsoft Code Analysis CLI](https://aka.ms/mscadocs) is built with dotnet v3.1.201. | ||
| # A version greater than or equal to v3.1.201 of dotnet must be installed on the agent in order to run this action. | ||
| # Remote agents already have a compatible version of dotnet installed and this step may be skipped. | ||
| # For local agents, ensure dotnet version 3.1.201 or later is installed by including this action: | ||
| # - uses: actions/setup-dotnet@v1 | ||
| # with: | ||
| # dotnet-version: '3.1.x' | ||
|
|
||
| # Run .NET Analyzers | ||
| - name: Run .NET Analyzers | ||
| uses: ./ | ||
|
There was a problem hiding this comment. Not sure if we want to upload results from .NET analyzers run to security tab or not, as the analyzers are not restricted to just security analyzers. Will have to talk with @mikadumont to decide There was a problem hiding this comment. GitHub would prefer if only security results were in the tab, as noise will make people not pay attention to critical issues. Should likely remove this for now. There may be a way to selectively export security-only rules with Guardian and a policy, although I am unfamiliar if we have that capability now. |
||
| id: dotnet-analyzers | ||
| with: | ||
| projects: samples\ClassLibrary1.sln | ||
mavasani marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,17 @@ | ||
| # sample-workflow-windows-latest | ||
| # docs are in the repo | ||
|
|
||
| name: .NET Analyzers windows-latest | ||
| on: | ||
| push: | ||
| branches: | ||
| - main | ||
|
|
||
| jobs: | ||
| sample: | ||
| name: .NET Analyzers runner | ||
|
|
||
| # .NET Analyzers runs on windows-latest. | ||
| # ubuntu-latest and macos-latest supporting coming soon | ||
| runs-on: windows-latest | ||
|
|
||
|
|
@@ -21,21 +21,15 @@ jobs: | |
| - uses: actions/checkout@v2 | ||
|
|
||
| # Ensure a compatible version of dotnet is installed. | ||
| # The [Microsoft Code Analysis CLI](https://aka.ms/mscadocs) is built with dotnet v3.1.201. | ||
| # A version greater than or equal to v3.1.201 of dotnet must be installed on the agent in order to run this action. | ||
| # GitHub hosted runners already have a compatible version of dotnet installed and this step may be skipped. | ||
| # For self-hosted runners, ensure dotnet version 3.1.201 or later is installed by including this action: | ||
| # - uses: actions/setup-dotnet@v1 | ||
| # with: | ||
| # dotnet-version: '3.1.x' | ||
|
|
||
| # Run .NET Analyzers | ||
| - name: Run .NET Analyzers | ||
| uses: github/dotnet-analyzers-action@v1 | ||
|
There was a problem hiding this comment. This will likely be the new repo URL, but have to confirm with @mikadumont There was a problem hiding this comment. Shouldnt it be called code-analysis? There was a problem hiding this comment. Yep, I will fix it up in the cloned repo. |
||
| id: dotnet-analyzers | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,61 @@ | ||
| name: 'dotnet-analyzers-action' | ||
| description: 'Run .NET code quality and code style analyzers shipping with .NET SDK' | ||
| author: 'GitHub' | ||
| inputs: | ||
| projects: | ||
| description: 'Semi-colon separated list of projects or solutions to analyze' | ||
| required: true | ||
| analysis-level: # AnalysisLevel: https://docs.microsoft.com/dotnet/core/project-sdk/msbuild-props#analysislevel | ||
| description: 'Default analysis level for all rules' | ||
| required: false | ||
| default: 'latest-minimum' | ||
| style: # AnalysisLevelStyle: https://docs.microsoft.com/dotnet/core/project-sdk/msbuild-props#analysislevel | ||
| description: 'Overridden analysis level for code style rules: https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/' | ||
| required: false | ||
| default: 'latest-minimum' | ||
| design: # AnalysisLevelDesign: https://docs.microsoft.com/dotnet/core/project-sdk/msbuild-props#analysislevel | ||
| description: 'Overridden analysis level for sesign rules: https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/design-warnings' | ||
| required: false | ||
| default: 'latest-minimum' | ||
| documentation: # AnalysisLevelDocumentation: https://docs.microsoft.com/dotnet/core/project-sdk/msbuild-props#analysislevel | ||
| description: 'Overridden analysis level for documentation rules: https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/documentation-warnings' | ||
| required: false | ||
| default: 'latest-minimum' | ||
| globalization: # AnalysisLevelGlobalization: https://docs.microsoft.com/dotnet/core/project-sdk/msbuild-props#analysislevel | ||
| description: 'Overridden analysis level for globalization rules: https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/globalization-warnings' | ||
| required: false | ||
| default: 'latest-minimum' | ||
| interoperability: # AnalysisLevelInteroperability: https://docs.microsoft.com/dotnet/core/project-sdk/msbuild-props#analysislevel | ||
| description: 'Overridden analysis level for portability and interoperability rules: https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/interoperability-warnings' | ||
| required: false | ||
| default: 'latest-minimum' | ||
| maintainability: # AnalysisLevelMaintainability: https://docs.microsoft.com/dotnet/core/project-sdk/msbuild-props#analysislevel | ||
| description: 'Overridden analysis level for maintainability rules: https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/maintainability-warnings' | ||
| required: false | ||
| default: 'latest-minimum' | ||
| naming: # AnalysisLevelNaming: https://docs.microsoft.com/dotnet/core/project-sdk/msbuild-props#analysislevel | ||
| description: 'Overridden analysis level for naming rules: https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/naming-warnings' | ||
| required: false | ||
| default: 'latest-minimum' | ||
| performance: # AnalysisLevelPerformance: https://docs.microsoft.com/dotnet/core/project-sdk/msbuild-props#analysislevel | ||
| description: 'Overridden analysis level for performance rules: https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/performance-warnings' | ||
| required: false | ||
| default: 'latest-minimum' | ||
| reliability: # AnalysisLevelReliability: https://docs.microsoft.com/dotnet/core/project-sdk/msbuild-props#analysislevel | ||
| description: 'Overridden analysis level for reliability rules: https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/reliability-warnings' | ||
| required: false | ||
| default: 'latest-minimum' | ||
| security: # AnalysisLevelSecurity: https://docs.microsoft.com/dotnet/core/project-sdk/msbuild-props#analysislevel | ||
| description: 'Overridden analysis level for security rules https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/security-warnings' | ||
| required: false | ||
| default: 'latest-minimum' | ||
| usage: # AnalysisLevelPerformance: https://docs.microsoft.com/dotnet/core/project-sdk/msbuild-props#analysislevel | ||
| description: 'Overridden analysis level for usage rules: https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/usage-warnings' | ||
| required: false | ||
| default: 'latest-minimum' | ||
| outputs: | ||
| sarifFile: | ||
| description: A file path to a SARIF file with analysis results. | ||
| runs: | ||
| using: 'node12' | ||
| main: 'lib/action.js' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.