Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Search Bar Functionality #3323

Closed
wants to merge 11 commits into from
Closed

Conversation

avanimathur
Copy link

  • Have you followed the contributing guidelines?
  • Have you explained what your changes do, and why they add value to the Guides?

Description

The search bar provides users with the opportunity to search for articles without deeply browsing the website. It is especially helpful when the user is looking for precise information and has limited time.
Thus, I have implemented a search bar function.

screen-capture.1.webm

Please review the changes.
This contribution is under Hacktoberfest'24 .

khalilmosavi

This comment was marked as spam.

@jmeridth
Copy link
Member

A search capability addition is interesting but the current UI placement (top left above navbar) of the search box is not good. I would suggest adding it to the navbar and also populating results in the main portion of the page or a modal.

Also the dataset to search upon is a static file that would need to be updated with site content. How will it be updated?

This PR feels incomplete IMO.

Do you have additional changes incoming?

I will communicate with other maintainers to see if this implementation/feature is something we're interested in.

@jmeridth
Copy link
Member

@avanimathur based on lack of response and sparse updates, looking to possibly use deployments for something I'm closing this one. Willing to be proven wrong.

@github github locked and limited conversation to collaborators Oct 26, 2024
@jmeridth jmeridth closed this Oct 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants