Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to latest jekyll and ruby and devcontainer #3319

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

jmeridth
Copy link
Member

@jmeridth jmeridth commented Oct 19, 2024

  • Have you followed the contributing guidelines?
  • Have you explained what your changes do, and why they add value to the Guides?

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.


  • latest jekyll
  • ruby 3.3.5
  • devcontainer setup also
    • allows us to work in environment matching prod
    • was getting error locally when trying to run bundle install, this is easier IMO
  • update dependabot config for npm
  • removed Gemfile.lock from .gitignore so dependabot can actually issue gem updates

@jmeridth jmeridth self-assigned this Oct 19, 2024
@jmeridth jmeridth requested a review from a team as a code owner October 19, 2024 03:33
@jmeridth jmeridth force-pushed the gm_upgrade_jeykyll_ruby_add_devcontainer branch from efcc69c to b44b8e9 Compare October 19, 2024 03:37
@jmeridth jmeridth force-pushed the gm_upgrade_jeykyll_ruby_add_devcontainer branch from b44b8e9 to c082557 Compare October 19, 2024 03:43
- [x] latest jekyll
- [x] ruby 3.3.5
- [x] devcontainer setup also
  - allows us to work in environment matching prod
  - was getting errorlocally when trying to run bundle install, this is easier IMO
- [x] update dependabot config for npm
- [x] removed Gemfile.lock from .gitignore so dependabot can actually issue gem updates

Signed-off-by: jmeridth <[email protected]>
@jmeridth jmeridth added this pull request to the merge queue Oct 21, 2024
Merged via the queue into main with commit 901aefb Oct 21, 2024
7 checks passed
@jmeridth jmeridth deleted the gm_upgrade_jeykyll_ruby_add_devcontainer branch October 21, 2024 16:08
Copy link

@khalilmosavi khalilmosavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gm_upgrade_jeykyll_ruby_add_devcontainer

@@ -0,0 +1,19 @@
{
"name": "Jekyll website",
"image": "mcr.microsoft.com/devcontainers/jekyll:latest",

This comment was marked as spam.

"version": "22"
},
"ghcr.io/devcontainers/features/ruby:1": {
"version": "3.3.5"

This comment was marked as spam.

This comment was marked as spam.

time: "10:00"
timezone: Europe/Vienna
pull-request-branch-name:
separator: "-"
open-pull-requests-limit: 99

This comment was marked as spam.

@@ -10,4 +10,3 @@ bin
css/main.scss
test/node_modules
test/package-lock.json
Gemfile.lock

This comment was marked as spam.

@@ -1 +1 @@
3.2
3.3.5

This comment was marked as spam.

@@ -1,6 +1,6 @@
source "https://rubygems.org"

gem "github-pages", group: :jekyll_plugins
gem "github-pages", "~> 232", group: :jekyll_plugins

This comment was marked as spam.

jekyll-seo-tag (~> 2.0)
jekyll-theme-primer (0.6.0)
jekyll (> 3.5, < 5.0)
jekyll-github-metadata (~> 2.9)

This comment was marked as spam.

@github github locked and limited conversation to collaborators Oct 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants