-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade to latest jekyll and ruby and devcontainer #3319
Conversation
efcc69c
to
b44b8e9
Compare
b44b8e9
to
c082557
Compare
- [x] latest jekyll - [x] ruby 3.3.5 - [x] devcontainer setup also - allows us to work in environment matching prod - was getting errorlocally when trying to run bundle install, this is easier IMO - [x] update dependabot config for npm - [x] removed Gemfile.lock from .gitignore so dependabot can actually issue gem updates Signed-off-by: jmeridth <[email protected]>
c082557
to
c591be9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gm_upgrade_jeykyll_ruby_add_devcontainer
@@ -0,0 +1,19 @@ | |||
{ | |||
"name": "Jekyll website", | |||
"image": "mcr.microsoft.com/devcontainers/jekyll:latest", |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
"version": "22" | ||
}, | ||
"ghcr.io/devcontainers/features/ruby:1": { | ||
"version": "3.3.5" |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
time: "10:00" | ||
timezone: Europe/Vienna | ||
pull-request-branch-name: | ||
separator: "-" | ||
open-pull-requests-limit: 99 |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
@@ -10,4 +10,3 @@ bin | |||
css/main.scss | |||
test/node_modules | |||
test/package-lock.json | |||
Gemfile.lock |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
@@ -1 +1 @@ | |||
3.2 | |||
3.3.5 |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
@@ -1,6 +1,6 @@ | |||
source "https://rubygems.org" | |||
|
|||
gem "github-pages", group: :jekyll_plugins | |||
gem "github-pages", "~> 232", group: :jekyll_plugins |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
jekyll-seo-tag (~> 2.0) | ||
jekyll-theme-primer (0.6.0) | ||
jekyll (> 3.5, < 5.0) | ||
jekyll-github-metadata (~> 2.9) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.