rst: use align-attribute for images #179
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docutils uses css-classes (e.g. align-right) but css-classes are stripped later on, which breaks image alignment. Using the HTML align-attribute the alignment works without css too.
|
+1. This would be great to have supported. |
|
In HTML5 the align attribute has been deprecated. |
|
Align is deprecated in HTML5: http://stackoverflow.com/questions/14551305/align-attribute-deprecated |
|
Wouldn't it be better to translate RST's Using CSS is the way advised by the W3Schools:
So for example this RST .. image :: http://example.com/favicon.ico
:align: rightcould become this HTML <img src="http://example.com/favicon.ico" style="float:right" />and this RST .. image :: http://example.com/favicon.ico
:align: topwould become this HTML <img src="http://example.com/favicon.ico" style="vertical-align:top" /> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment it is impossible to change the image alignment when using restructured text on github (see #163).
The docutils
HTMLTranslatoris using css-classes for alignment, which are stripped by github later.Using the HTML align attribute would be more appropriate, I think.
This pull-request adds the alignment value from restructured text in
figureandimagestatements asalignvalue to the HTMLimgtag.I'm not sure whether this is the way it should be for github, but I think it should work well.