Don't set a tabindex=0 when the toolbar has data-no-focus attribute applied #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hello and thanks for pinging us! This issue or PR has been added to our inbox and a Primer first responder will review it soon.
|
langermank
approved these changes
Sep 11, 2023
TylerJDev
reviewed
Sep 22, 2023
| @@ -366,7 +367,6 @@ function focusKeydown(event: KeyboardEvent) { | |||
| if (key !== 'ArrowRight' && key !== 'ArrowLeft' && key !== 'Home' && key !== 'End') return | |||
| const toolbar = event.currentTarget | |||
| if (!(toolbar instanceof HTMLElement)) return | |||
| if (toolbar.hasAttribute('data-no-focus')) return | |||
There was a problem hiding this comment.
Does this line need to be removed? I see it prevents arrow keys from functioning when the toolbar has the attribute.
keithamus
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
markdown-toolbarelement is grabbing focus when usingdata-no-focus. I think this is because of the tabindex that's being applied.To fix this, I'm moving the
this.hasAttribute('data-no-focus')into the connectedCallback constructor and also avoiding adding eventListeners when this occurs