Cococapods enumeration using cocoapods plugin #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. use local gemfile with cocoapods and cocoapods-dependencies-list plugin 2. update to cocoapods 1.12.x
|
cc @LouisBoudreau FYI I'm going to merge this and put out a new release of licensed with cocoapods enabled. If you have cocoapods projects that you were planning to use licensed for, could you give the new release a try when it's out and let m know how everything works out between licensed, the cocoapods plugin, or anything else related to this integration? |
jonabc
added a commit
that referenced
this pull request
Mar 20, 2023
### Added - Cocoapods support has been re-enabled using a cocoapods plugin (#644)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #636
This PR adds support for cocoapods without introducing a direct dependency on the cocoapods-core gem. See the linked issue for full context, with a TL;DR that the additional nested dependency version requirements on common gems included from cocoapods-core made it difficult for downstream licensed users to install licensed alongside other usages of those same dependencies.
As an alternative approach to taking a direct dependency on the cocoapods-core gem, I created a
podCLI plugin at jonabc/cocoapods-dependencies-list which outputs dependency information as JSON. The plugin was made pretty specifically for licensed but I suppose it's possible for the data output to be used by other tools as well. I searched rubygems for a plugin that might already support licensed's usage but it looked like all existing plugins output graph visualizations of dependencies.This PR uses the new plugin to enumerate cocoapods dependencies without taking any hard dependencies on cocoapods gems.