Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add owner and repository names to errors #249

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

jmeridth
Copy link
Member

@jmeridth jmeridth commented Apr 23, 2024

Fixes #234

Pull Request

Proposed Changes

Add owner and repository info to error messages

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run make lint and fix any issues that you have introduced
  • run make test and ensure you have test coverage for the lines you are introducing

Reviewer

  • Label as either fix, documentation, enhancement, infrastructure, or breaking

Add owner and repository info to error messages

Signed-off-by: jmeridth <[email protected]>
@jmeridth
Copy link
Member Author

@zkoppert got rid of the duplicate code and went with a dictionary. Easier to set, access and default to None when key not present.

Copy link
Member

@zkoppert zkoppert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jmeridth jmeridth merged commit 95d854c into main Apr 23, 2024
27 checks passed
@jmeridth jmeridth deleted the jm-improve-error-message branch April 23, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve error message
2 participants