Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): support reading from local file if it exists #48

Merged
merged 1 commit into from
Nov 8, 2023
Merged

feat(config): support reading from local file if it exists #48

merged 1 commit into from
Nov 8, 2023

Conversation

lrstanley
Copy link
Contributor

@lrstanley lrstanley commented Jun 25, 2022

Currently, actions/issue-labeler can only read the configuration from the source repository, due to it using the context and API to fetch the configuration file. This PR adds support for first checking to see if a file matching the provided path exists locally, before it makes a call to the API to get the file.

The primary benefit for this, is it works well with reusable workflows, as all you have to do is grab the file from a central location, before running this on the target repository.

Example action run with these changes: https://github.com/lrstanley/clix/actions/runs/6504026420/job/17665376086

@lrstanley lrstanley changed the title add notBefore functionality as per#2(#3) feat(config): support reading from local file if it exists Jun 25, 2022
@stephanmiehe
Copy link
Collaborator

Please make the target branch main and run npm run build to generate the JS

@lrstanley lrstanley marked this pull request as draft October 13, 2023 04:02
@lrstanley lrstanley changed the base branch from releases/v2.5 to master October 13, 2023 04:20
@lrstanley lrstanley marked this pull request as ready for review October 13, 2023 04:31
@lrstanley
Copy link
Contributor Author

@stephanmiehe done!

Also worth mentioning that I recently added this to actions/labeler a few months ago as well, in this pr.

@stephanmiehe stephanmiehe merged commit 6bea9ed into github:master Nov 8, 2023
ghost referenced this pull request in camunda/camunda Nov 9, 2023
15109: deps(github-tags) Update github/issue-labeler action to v3.3 (main) r=github-actions[bot] a=renovate[bot]

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [github/issue-labeler](https://github.com/github/issue-labeler) | action | minor | `v3.2` -> `v3.3` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency Dashboard for more information.

---

### Release Notes

<details>
<summary>github/issue-labeler (github/issue-labeler)</summary>

### [`v3.3`](https://github.com/github/issue-labeler/releases/tag/v3.3)

[Compare Source](https://github.com/github/issue-labeler/compare/v3.2...v3.3)

#### What's Changed

-   feat(config): support reading from local file if it exists by [`@&#8203;lrstanley](https://github.com/lrstanley)` in [https://github.com/github/issue-labeler/pull/48](https://github.com/github/issue-labeler/pull/48)

#### New Contributors

-   [`@&#8203;lrstanley](https://github.com/lrstanley)` made their first contribution in [https://github.com/github/issue-labeler/pull/48](https://github.com/github/issue-labeler/pull/48)

**Full Changelog**: github/issue-labeler@v3.2...v3.3

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "every weekday" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/camunda/zeebe).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40Ni4wIiwidXBkYXRlZEluVmVyIjoiMzcuNDYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->


Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
kodiakhq bot referenced this pull request in X-oss-byte/Canary-nextjs Nov 11, 2023
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [github/issue-labeler](https://github.com/github/issue-labeler) | action | minor | `v3.2` -> `v3.3` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency Dashboard for more information.

---

### Release Notes

<details>
<summary>github/issue-labeler (github/issue-labeler)</summary>

### [`v3.3`](https://github.com/github/issue-labeler/releases/tag/v3.3)

[Compare Source](https://github.com/github/issue-labeler/compare/v3.2...v3.3)

#### What's Changed

-   feat(config): support reading from local file if it exists by [@&#8203;lrstanley](https://github.com/lrstanley) in [https://github.com/github/issue-labeler/pull/48](https://github.com/github/issue-labeler/pull/48)

#### New Contributors

-   [@&#8203;lrstanley](https://github.com/lrstanley) made their first contribution in [https://github.com/github/issue-labeler/pull/48](https://github.com/github/issue-labeler/pull/48)

**Full Changelog**: github/issue-labeler@v3.2...v3.3

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/X-oss-byte/Canary-nextjs).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support reading from filesystem rather than using the API to fetch configuration file
2 participants