Added support for multiple actions #1604
Conversation
We wanted to be able to trigger multiple events in a sequence with eardropping but the existing implementation would trigger events in an almost random order. Added an order parameter to the task object and set up a bit to sort tasks that match the current eardrop trigger. I'm quite new to coffeescript and hubot programming so there's probably some room to refactor my additions. The ordering still isn't 100% accurate. Hubot will trigger the tasks in the correct sequence but target actions may appear to the user out of order. For example, when hubot hears "kaboom" it should trigger "how many days since kaboom?", then echo <url to a gif> and finally reset the days since kaboom counter to 0. On the server side, this executes in the desired order but on client side, those messages might be received out of sequence.
| tasks.sort (a,b) -> | ||
| return if a.order >= b.order then 1 else -1 | ||
|
|
||
| console.log "Tasks: #{tasks}" |
There was a problem hiding this comment.
This looks like a debugging statement to remove. At the very least, I'd use robot.logger.debug instead so HUBOT_LOG_LEVEL is respected.
|
Took out the debug line, it wasn't a terribly useful one anyway. |
|
We are actually moving away from adding scripts to repository in favor of separate npm packages per scripts. We have already stopped accepting new scripts, and will stop accepting pull requests on this repository after hubot 3.0. See #1113 for details. If you are interested in maintaining this longer term, check npm in case someone already made a package for it, and if not, check out https://hubot.github.com/docs/scripting/ for creating a package of your own. |
Added support for multiple actions
|
Not sure if I put this PR in before or after the repo breakup but I'm aware and will be working on the separate repos should the need arise. Thanks for the merge! |
|
@inhumantsar no problem! If you do split out a pacakge, please drop an update on #1641 with a link to the new home. |
We wanted to be able to trigger multiple events in a sequence with eardropping but the existing implementation would trigger events in an almost random order. Added an order parameter to the task object and set up a bit to sort tasks that match the current eardrop trigger. I'm quite new to coffeescript and hubot programming so there's probably some room to refactor my additions.
The ordering still isn't 100% accurate. Hubot will trigger the tasks in the correct sequence but target actions may appear to the user out of order. For example, when hubot hears "kaboom" it should trigger "how many days since kaboom?", then echo and finally reset the days since kaboom counter to 0. On the server side, this executes in the desired order but on client side, those messages might be received out of sequence.