Instagram script to fetch images for a given hash tag #1150
Conversation
|
In the spirit of #1113, we're recommending folks start packages for new scripts rather than adding to this repository. See that issue for details, and let us know if you have any questions! |
| client_secret: process.env.HUBOT_INSTAGRAM_ACCESS_KEY | ||
|
|
||
| Instagram = require('instagram-node-lib') | ||
| Instagram.set('client_id', config.client_key); |
There was a problem hiding this comment.
What happens if config.client_key isn't set in the environment? does Instagram complain? If it does, should consider moving this to the authenticate_user method. Besides that, the name of the method makes it sound like that will happen.
|
@raysrashmi I left you some suggestions in-line. If you do go ahead with making a separate package, I might suggest namespacing it like hubot-instagram-tag |
|
@technicalpickles thank you so much for reviewing this . now making a packing will keep in mind all the suggestions you given |
|
I have created a separate package https://github.com/raysrashmi/hubot-instagram and create a issue for this hubot-archive/packages#6 @technicalpickles i named package "hubot-instagram" because will add more script in to this |
|
The fork is done, so can close this one out. Folks using hubot-scripts will still have issues though, so might be worth making a new PR to mark it as deprecated with pointer to new one, @raysrashmi |
No description provided.