Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Godot.gitignore to ignore export_credentials.cfg #4588

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

sdepouw
Copy link
Contributor

@sdepouw sdepouw commented Feb 21, 2025

As of May 2023, export_presets.cfg no longer contains sensitive information in Godot. Sensitive information now resides in export_credentials.cfg

Reasons for making this change:

When starting to use Godot, I searched for .gitignore files and found this repository. I saw that it was out of date compared to changes made to Godot that are nearly two years old as of the time of making this PR.

Links to documentation supporting these rule changes:

This Godot Pull Request shows the change being made to no longer store sensitive information in export_presets.cfg, and instead place them in export_crednetials.cfg. Here is the completed proposal. Quoting the proposal:

Godot stores export settings including which resources to bundle, app icons, export capabilities in the export_presets.cfg. These settings are a core part of development, and we normally want to include these in source control. Unfortunately Godot also stores the keystore credentials in the same export file. This means we either have to commit credentials to our repo, or we have to manually recreate the presets between developers, and somehow sync changes. Both are really bad options. [...] It would be better to have keystore credentials in their own config file alongside exports_presets.cfg. Something like exports_credentials.cfg or similar.

As of godotengine/godot#76165, export_presets.cfg no longer contains sensitive information. Sensitive information now resides in export_credentials.cfg
@thorrsson thorrsson merged commit e6b8c0e into github:main Feb 21, 2025
@sdepouw sdepouw deleted the patch-1 branch February 21, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants