-
Notifications
You must be signed in to change notification settings - Fork 83.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Node.gitignore to include VitePress #4543
Conversation
Include VitePress
@NdagiStanley could you provide some links to documentation supporting the change? |
@wirecat The modification reference can be found in the official VitePress documentation here: https://vitepress.dev/guide/getting-started#file-structure It mentions:
|
@NdagiStanley Please note that the VitePress temp and cache directory is |
You are right @caipeter888. I've updated the PR. |
However, the |
Good point @caipeter888 That said, judging by how vuepress was handled, I believe the reasoning is to handle the default case and leave it to the developer who restructures the folders, to update the pattern. I'll make the edit anyway. |
Node.gitignore
Outdated
# vuepress v2.x temp and cache directory | ||
.temp | ||
.cache | ||
|
||
# vitepress temp and cache directory | ||
**/.vitepress/temp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this line is unnecessary since the VitePress documentation does not mention using a temp
folder. If I’ve missed something, please point it out. Otherwise, it seems safe to omit this line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right.
In the Tip section of the docs here, it points to only cache
and dist
folders.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Thank you to everyone for the contributions on this one! |
Include VitePress
Reasons for making this change:
I noticed that VuePress is included in the current gitignore. VuePress has been succeeded by VitePress. This change includes files to be ignored in a VitePress project.