-
Notifications
You must be signed in to change notification settings - Fork 83.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Python.gitignore for .ruff_cache/ #4289
Conversation
Add ruff cache. ruff tool: https://github.com/charliermarsh/ruff ruff is becoming a very popular tool often run in pre-commit and aim to replace Flake8 (plus dozens of plugins), isort, pydocstyle, yesqa, eradicate, pyupgrade, and autoflake, all while executing tens or hundreds of times faster than any individual tool.
See also #4199 |
I think this is not required, as ruff will add a See astral-sh/ruff#204 and astral-sh/ruff#208 |
It is nicer to have it there. e.g. PyCharm's excluded folders (and https://plugins.jetbrains.com/plugin/17288-foldable-projectview) work based on these ignores |
@JasperJuergensen |
I agree that it is nice to have the Also was mentioned in #4199 and #4274 PRs. For instance, without the |
Other tools like |
Can we get some maintainer focus? e.g. @dooleydevin? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late feedback! LGTM and will with the next update of our templates 😄
I'll handle the merge conflicts here too just to move things along since this PR is a bit old.
Add Ruff cache in gitignore.
Ruff is becoming a very popular tool often run in pre-commit and aim to replace Flake8 (plus dozens of plugins), isort, pydocstyle, yesqa, eradicate, pyupgrade, and autoflake, all while executing tens or hundreds of times faster than any individual tool.
Reasons for making this change:
Ruff is run in pre-commit thus .ruff_cache/ could be included accidently in git.
Actually this is similar to .mypy_cache/ which is also run in pre-commit.
Links to documentation supporting these rule changes:
https://github.com/charliermarsh/ruff in section configuration we can see the exclude of .ruff_cache and .mypy_cache