feat: add golangci-lint-action to the lint workflow#407
Merged
SamMorrowDrums merged 3 commits intogithub:mainfrom May 19, 2025
Merged
feat: add golangci-lint-action to the lint workflow#407SamMorrowDrums merged 3 commits intogithub:mainfrom
golangci-lint-action to the lint workflow#407SamMorrowDrums merged 3 commits intogithub:mainfrom
Conversation
Collaborator
SamMorrowDrums
left a comment
SamMorrowDrums
left a comment
There was a problem hiding this comment.
I love the simplicity just need to verify it doesn't this miss a couple of the checks from the existing implementation before merging.
williammartin
requested changes
May 19, 2025
Collaborator
There was a problem hiding this comment.
@radar07 thanks for doing this but it loses the go mod checks. Please ensure this still does go mod verify and asserts nothing has changed after go mod tidy.
It's ok to lose go fmt because golangci-lint does include that check.
Contributor
Author
|
@williammartin I missed this totally. I removed the |
radar07
force-pushed
the
add-golangci-lint-action
branch
from
14ed0ce to
b620cc5
Compare
SamMorrowDrums
approved these changes
May 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #406