Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.1.5 #1144

Open
wants to merge 25 commits into
base: master
Choose a base branch
from
Open

v1.1.5 #1144

Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
d8ccc11
v1.1.3
eddroid Jul 27, 2021
0a87c7a
Add flag to customize the interval which the onStatus hook is called
tknodell-recurly Feb 1, 2022
dd919de
Add docs for `hooks-status-interval`
dm-2 Feb 7, 2022
62ac897
Reduce the minimal chunk size from `100` to `10`.
arthurschreiber Feb 7, 2022
7c9c1f0
v1.1.4
dm-2 Feb 7, 2022
0ba4762
fix: update build script to explicitly build RPMs for linux
dm-2 Feb 25, 2022
9b27d91
Use `.String()` for logging connection-config `InstanceKey`
timvaillancourt Feb 23, 2022
869ed92
Fix needless `fmt.Sprintf` call in `go/logic/inspector.go`
timvaillancourt Feb 24, 2022
63c171d
Add binaries for arm64 architectures
jecepeda Mar 11, 2022
8dd1571
Add `golangci-lint` CI action, fix `gosimple`, `govet` + `unused` lin…
timvaillancourt May 31, 2022
6598b34
Fix `integer divide by zero` panic in migrator
timvaillancourt Jun 23, 2022
e0d31ba
fix(lost data in mysql two-phase commit): lost data in mysql two-phas…
shaohk Jun 24, 2022
fcda553
Run CodeQL analysis on PRs
dm-2 Jul 6, 2022
9e0808a
compound pk tests (#387)
shlomi-noach Jul 6, 2022
68b4085
Ensure mysql rows responses are closed (#1132)
timvaillancourt Jul 6, 2022
b4566de
Use `switch` statements for readability, simplify `.NewGoMySQLReader(…
timvaillancourt Jul 6, 2022
614b379
Add context/timeout to HTTP throttle check (#1131)
timvaillancourt Jul 6, 2022
3e72f1b
Cancel any row count queries before attempting to cut over (#846)
ajm188 Jul 6, 2022
0adb697
v1.1.5
dm-2 Jul 7, 2022
f29e63b
Check RowsAffected when applying DML events to get more accurate stat…
ajm188 Jul 14, 2021
f2c2033
vendor github.com/openark/golib
dm-2 Jul 7, 2022
36d3800
Only build RPM and deb packages for amd64
dm-2 Jul 20, 2022
8cdd30a
Focal build
rashiq Oct 5, 2023
bd46b5a
Merge pull request #1321 from github/release-1.1.5-focal
rashiq Oct 6, 2023
49c1e33
Fix focal build
rashiq Oct 6, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix needless fmt.Sprintf call in go/logic/inspector.go
timvaillancourt authored and dm-2 committed Jul 7, 2022
commit 869ed92400182d934db6918f0967d6718292612f
2 changes: 1 addition & 1 deletion go/logic/inspect.go
Original file line number Diff line number Diff line change
@@ -348,7 +348,7 @@ func (this *Inspector) validateBinlogs() error {
if !this.migrationContext.SwitchToRowBinlogFormat {
return fmt.Errorf("You must be using ROW binlog format. I can switch it for you, provided --switch-to-rbr and that %s doesn't have replicas", this.connectionConfig.Key.String())
}
query := fmt.Sprintf(`show /* gh-ost */ slave hosts`)
query := `show /* gh-ost */ slave hosts`
countReplicas := 0
err := sqlutils.QueryRowsMap(this.db, query, func(rowMap sqlutils.RowMap) error {
countReplicas++