Fix --version output (#1352)

* Fix `--version` output Signed-off-by: Tim Vaillancourt <[email protected]> * Always fallback version/commit if undef Signed-off-by: Tim Vaillancourt <[email protected]> --------- Signed-off-by: Tim Vaillancourt <[email protected]>
github · Dec 11, 2023 · 679d39e · 679d39e
1 parent 5ebb953
commit 679d39e
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/go/cmd/gh-ost/main.go b/go/cmd/gh-ost/main.go
@@ -160,12 +160,15 @@ func main() {
 		flag.PrintDefaults()
 		return
 	}
+
+	if AppVersion == "" {
+		AppVersion = "unversioned"
+	}
+	if GitCommit == "" {
+		GitCommit = "unknown"
+	}
 	if *version {
-		appVersion := AppVersion
-		if appVersion == "" {
-			appVersion = "unversioned"
-		}
-		fmt.Printf("%s (git commit: %s)", appVersion, GitCommit)
+		fmt.Printf("%s (git commit: %s)\n", AppVersion, GitCommit)
 		return
 	}