Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add progress report when uploading migration archives to Azure Blob or AWS S3 #1311

Merged

Conversation

ArinGhazarian
Copy link
Collaborator

@ArinGhazarian ArinGhazarian commented Dec 7, 2024

Closes https://github.ghe.com/github/octoshift/issues/9735

This PR adds the following:

  1. Adds progress reports when uploading migration archives to Azure Blob or AWS S3 to the gh [gei|bbs2gh] migrate-repo commands.

Sample progress report when uploading to AWS S3:

image

Sample progress report when uploading to Azure blob:

image

  1. Additionally I made the OctoLogger thread safe by using a shared mutex object for all public log methods.
  • Did you write/update appropriate tests
  • Release notes updated (if appropriate)
  • Appropriate logging output
  • Issue linked
  • Docs updated (or issue created)
  • New package licenses are added to ThirdPartyNotices.txt (if applicable)

@ArinGhazarian ArinGhazarian marked this pull request as ready for review December 7, 2024 05:38
Copy link

github-actions bot commented Dec 7, 2024

Unit Test Results

841 tests   841 ✅  20s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit 79ee21c.

♻️ This comment has been updated with latest results.

Copy link

Code Coverage

Package Line Rate Branch Rate Complexity Health
gei 81% 72% 584
ado2gh 84% 78% 631
Octoshift 87% 76% 1344
bbs2gh 79% 74% 692
Summary 84% (7175 / 8562) 75% (1648 / 2198) 3251

Copy link

@iomekam iomekam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ArinGhazarian ArinGhazarian merged commit 5ef3b27 into main Dec 11, 2024
30 checks passed
@ArinGhazarian ArinGhazarian deleted the add-upload-archive-progress-report-for-aws-and-azure branch December 11, 2024 21:29
Copy link
Contributor

@jeviet jeviet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based upon conversation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants