Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GHES generate script to accept --use-github-storage option #1291

Merged
merged 15 commits into from
Nov 6, 2024
Merged

Update GHES generate script to accept --use-github-storage option #1291

merged 15 commits into from
Nov 6, 2024

Conversation

begonaguereca
Copy link
Collaborator

@begonaguereca begonaguereca commented Nov 4, 2024 •
edited
Loading

Summary

Things happening in this PR:

  1. Add --use-github-storage to the GenerateScript command
  2. Update integration tests to use --use-github-storage command

Take it for a 🚗

export GH_PAT=<<PAT>> 

dotnet run --project src/gei/gei.csproj -- generate-script --github-source-org valet-testing --github-target-org octoshift-staging --use-github-storage true --ghes-api-url https://octoshift-ghe.westus2.cloudapp.azure.com/api/v3
  • Did you write/update appropriate tests
  • Release notes updated (if appropriate)
  • Appropriate logging output
  • Issue linked
  • Docs updated (or issue created)
  • New package licenses are added to ThirdPartyNotices.txt (if applicable)

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2024 •
edited
Loading

Unit Test Results

829 tests   829 ✅  23s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit f4e0d8b.

♻️ This comment has been updated with latest results.

@begonaguereca begonaguereca marked this pull request as ready for review November 5, 2024 02:04
@begonaguereca begonaguereca merged commit 5649673 into main Nov 6, 2024
29 of 30 checks passed
@begonaguereca begonaguereca deleted the generate-script-ghes branch November 6, 2024 19:15
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024

Code Coverage

Package Line Rate Branch Rate Complexity Health
gei 80% 71% 550 ✔
ado2gh 84% 78% 627 ✔
Octoshift 87% 76% 1298 ✔
bbs2gh 79% 74% 666 ✔
Summary 83% (7022 / 8410) 75% (1579 / 2098) 3141 ✔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArinGhazarian ArinGhazarian ArinGhazarian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@begonaguereca @ArinGhazarian