Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile our CLIs for non 64-bit non-ARM Windows machines (i.e. x86) #796

Closed
timrogers opened this issue Feb 2, 2023 · 0 comments · Fixed by #797
Closed

Compile our CLIs for non 64-bit non-ARM Windows machines (i.e. x86) #796

timrogers opened this issue Feb 2, 2023 · 0 comments · Fixed by #797
Labels

Comments

@timrogers
Copy link
Contributor

Right now, we don't compile the CLI for windows-386 during our build process. This causes issues when customers try to run the CLI on non-64-bit non-ARM Windows machines.

We should add this to our list of compilation targets.

windows-386 is a supported target for the GitHub CLI, so we're good from that perspective.

We will also need to consider how/if we test the resulting binaries.

@timrogers timrogers added the task label Feb 2, 2023
timrogers added a commit that referenced this issue Feb 2, 2023
…arget

This updates our release process to build each of our CLIs for x86 Windows devices (i.e. just about anything that isn't x64 or ARM!).

At this time, we don't have a way to test that these binaries work as part of our CI/CD process. Nevertheless, we think it's better to distribute a binary that should work than to offer nothing to users who want x86 support! If people run into any problems, they can create an issue and we will, of course, look into it.

Fixes #796.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant