Repository navigation
fix(compiler): normalize gateway policy server IDs #58023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
e314743
fix(setup): validate plural gateway agent IDs
lpcox 02c6f31
Merge remote-tracking branch 'origin/main' into lpcox-fix-multi-agent…
lpcox e4c9718
fix(compiler): normalize gateway policy server IDs
lpcox e8134c5
fix(compiler): defer shared enclave backends
lpcox 0f96a8a
fix(compiler): hand gateway key to enclave host
lpcox 706f86a
Merge branch 'main' into lpcox-fix-multi-agent-gateway-startup
github-actions[bot] 033e6e9
Merge branch 'main' into lpcox-fix-multi-agent-gateway-startup
github-actions[bot] 1e76031
fix(compiler): preserve deferred enclave readiness contract
Copilot f99cb04
Merge branch 'main' into lpcox-fix-multi-agent-gateway-startup
github-actions[bot] 332f6a1
docs: clarify gateway API key alias
Copilot 2c4ab8d
fix(cli): sync embedded workflow fallback manifest
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making
awf-enclaveglobally optional removes the fail-fast check for the deferred enclave path, so a broken enclave startup now escapes setup and only crashes later when the first enclave tool is invoked.💡 Why this blocks
The deferred-server export already solves the eager-connect problem; adding
"required": falseon top changes behavior again by telling the gateway that missing enclave connectivity is acceptable. That hides real startup defects such as a dead enclave process, bad capability header, or missing readiness handoff, and turns them into harder-to-debug runtime failures during agent execution.A safer fix is to preserve deferred startup while keeping an explicit readiness assertion before the agent step begins. If the gateway truly must tolerate a deferred backend here, the generated workflow needs a separate check that proves the enclave endpoint became reachable before any enclave tool can be used.