Skip to content

Compiler: redirect DOTNET_INSTALL_DIR and GOPATH for ARC/DinD topology #42855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lpcox merged 3 commits into from
Jul 2, 2026
Merged

Compiler: redirect DOTNET_INSTALL_DIR and GOPATH for ARC/DinD topology #42855

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
037950f
fix: redirect DOTNET_INSTALL_DIR and GOPATH for ARC/DinD topology
lpcox Jul 2, 2026
6b4fb79
test: add assertions for DOTNET_INSTALL_DIR and GOPATH redirects
lpcox Jul 2, 2026
d4338f1
Merge branch 'main' into fix/arc-dind-runtime-install-paths
github-actions[bot] Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pkg/workflow/compiler_yaml_main_job.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,10 +233,12 @@ func (c *Compiler) generateRuntimeAndWorkspaceSetupSteps(yaml *strings.Builder,
// This step must run before any runtime setup steps (setup-go, setup-node, etc.) so that
// those actions pick up the redirected path when they write into RUNNER_TOOL_CACHE.
if isArcDindTopology(data) {
yaml.WriteString(" - name: Redirect tool cache for ARC/DinD\n")
yaml.WriteString(" - name: Redirect tool cache and install paths for ARC/DinD\n")
yaml.WriteString(" run: |\n")
yaml.WriteString(" mkdir -p \"${RUNNER_TEMP}/gh-aw/tool-cache\"\n")
yaml.WriteString(" echo \"RUNNER_TOOL_CACHE=${RUNNER_TEMP}/gh-aw/tool-cache\" >> \"$GITHUB_ENV\"\n")
yaml.WriteString(" echo \"DOTNET_INSTALL_DIR=${RUNNER_TEMP}/gh-aw/tool-cache/dotnet\" >> \"$GITHUB_ENV\"\n")
yaml.WriteString(" echo \"GOPATH=${RUNNER_TEMP}/gh-aw/tool-cache/go\" >> \"$GITHUB_ENV\"\n")
}

if needsCheckout || !customStepsContainCheckout {
Expand Down
4 changes: 3 additions & 1 deletion pkg/workflow/compiler_yaml_main_job_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -748,9 +748,11 @@ func TestGenerateMainJobStepsArcDindRedirectsToolCacheToRunnerTemp(t *testing.T)
require.NoError(t, err)

result := yaml.String()
assert.Contains(t, result, "- name: Redirect tool cache for ARC/DinD")
assert.Contains(t, result, "- name: Redirect tool cache and install paths for ARC/DinD")
assert.Contains(t, result, `mkdir -p "${RUNNER_TEMP}/gh-aw/tool-cache"`)
assert.Contains(t, result, `echo "RUNNER_TOOL_CACHE=${RUNNER_TEMP}/gh-aw/tool-cache" >> "$GITHUB_ENV"`)
assert.Contains(t, result, `echo "DOTNET_INSTALL_DIR=${RUNNER_TEMP}/gh-aw/tool-cache/dotnet" >> "$GITHUB_ENV"`)
assert.Contains(t, result, `echo "GOPATH=${RUNNER_TEMP}/gh-aw/tool-cache/go" >> "$GITHUB_ENV"`)
assert.NotContains(t, result, "/tmp/gh-aw/tool-cache")
}

Expand Down
Loading