Repository navigation
Harden Pi smoke reflect fetch with startup retries, proxy bypass, diagnostics, and Node debug logging #35381
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,6 +12,10 @@ permissions: | |
| contents: read | ||
| issues: read | ||
| pull-requests: read | ||
| env: | ||
| AWF_REFLECT_MAX_ATTEMPTS: "7" | ||
|
Contributor
There was a problem hiding this comment. Consider documenting these AWF_REFLECT_* env vars in the workflow comment block for discoverability. |
||
| AWF_REFLECT_RETRY_BASE_MS: "1000" | ||
|
Contributor
There was a problem hiding this comment. The 10s ceiling pairs well with the 1s base. Worth a short comment to call out the implied exponential backoff envelope.
Contributor
There was a problem hiding this comment. Nit: a base of 1000ms is fairly conservative — consider exposing the override path in a small README so contributors can tune for slow environments.
Contributor
There was a problem hiding this comment. Acknowledged by the smoke test run: review-comment reply path verified on the latest existing review comment. Warning Firewall blocked 6 domainsThe following domains were blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "accounts.google.com"
- "android.clients.google.com"
- "clients2.google.com"
- "contentautofill.googleapis.com"
- "safebrowsingohttpgateway.googleapis.com"
- "www.google.com"See Network Configuration for more information.
|
||
| AWF_REFLECT_RETRY_MAX_MS: "10000" | ||
| name: Smoke Pi | ||
| experiments: | ||
| sub_agent_decomposition: | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider documenting the rationale for
AWF_REFLECT_MAX_ATTEMPTS=7so future maintainers know why this specific cap was chosen.