Skip to content

Add on.pull_request_reviewer: slash_command synthetic trigger and reviewer lifecycle routing #33273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 39 commits into from
May 19, 2026
Merged

Add on.pull_request_reviewer: slash_command synthetic trigger and reviewer lifecycle routing #33273

Show file tree
Hide file tree
Changes from 31 commits
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
ec9d834
Add pull_request_reviewer synthetic trigger lifecycle routing
Copilot May 19, 2026
355738b
Plan reviewer command uniqueness fix
Copilot May 19, 2026
17789b4
Enforce unique slash commands for pull_request_reviewer workflows
Copilot May 19, 2026
99877f5
Add doc comment for reviewer command uniqueness validator
Copilot May 19, 2026
4bb9817
Infer reviewer slash command id when missing
Copilot May 19, 2026
8a9a801
Document reviewer command inference normalization
Copilot May 19, 2026
e348900
Adjust reviewer routing for explicit commands and review requests
Copilot May 19, 2026
8473865
Switch Matt Pocock reviewer to pull_request_reviewer trigger
Copilot May 19, 2026
f2f8717
Fix Matt reviewer slash command event list
Copilot May 19, 2026
93df350
Relax reviewer trigger syntax and limit review lifecycle events
Copilot May 19, 2026
8f9a630
Refine reviewer trigger validation and review event filtering
Copilot May 19, 2026
249258b
Clarify reviewer trigger validation messaging
Copilot May 19, 2026
2416bf1
Polish reviewer trigger docs and validation text
Copilot May 19, 2026
e856a3c
Tighten reviewer trigger validation wording
Copilot May 19, 2026
6c4340f
Plan for reviewer feedback
Copilot May 19, 2026
040328e
Mark pull_request_reviewer trigger experimental and recompile
Copilot May 19, 2026
18b4e82
Harden reviewer experimental warning test file permissions
Copilot May 19, 2026
50fad96
Restore built-in reviewer slash routing and add status-comment reuse …
Copilot May 19, 2026
126954b
Polish reviewer command helper naming and add_comment compatibility l…
Copilot May 19, 2026
4c4cb89
Support add_comment target=status for status comment reuse
Copilot May 19, 2026
f6adb15
Tighten add_comment target=status validation
Copilot May 19, 2026
ff23052
Clarify add_comment target=status discussion error message
Copilot May 19, 2026
10a5fe1
Harden add_comment target validation error messages
Copilot May 19, 2026
de01057
Normalize target=status wording in discussion error
Copilot May 19, 2026
c8c2f98
Refine add_comment target enum validation wording
Copilot May 19, 2026
30c2063
Use shared allowed-targets list in add_comment validation
Copilot May 19, 2026
aed4944
Document reviewer trigger and add_comment status target in safe-outpu…
Copilot May 19, 2026
a6732bd
Clarify reviewer trigger forms and add explicit duplicate-command fai…
Copilot May 19, 2026
ce9062f
Align reviewer trigger precedence with spec defaults
Copilot May 19, 2026
2058abd
Merge branch 'main' into copilot/add-synthetic-trigger-pull-request-r…
pelikhan May 19, 2026
b5513b8
docs(adr): draft ADR-33273 synthetic pull_request_reviewer trigger
github-actions[bot] May 19, 2026
0ada598
Merge remote-tracking branch 'origin/main' into copilot/add-synthetic…
Copilot May 19, 2026
cd0fa13
Merge origin/main and recompile workflows
Copilot May 19, 2026
25333af
Plan review comment follow-up
Copilot May 19, 2026
c19943a
Address pending review feedback for reviewer trigger and add_comment …
Copilot May 19, 2026
f8289c7
Fix stale deprecated schema expectation
Copilot May 19, 2026
1e64579
Plan fix for CommandOtherEvents reviewer test
Copilot May 19, 2026
974fdba
Fix: populate CommandOtherEvents for pull_request_reviewer lifecycle …
Copilot May 19, 2026
4fe7148
Add changeset for reviewer trigger
github-actions[bot] May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions .github/workflows/agentic_commands.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# gh-aw-commands: {"payload_version":"v1","schema_version":"v1","compiler_version":"dev","commands":["ace","approach-validator","archie","brave","cloclo","craft","grumpy","mergefest","nit","plan","poem-bot","review","scout","security-review","summarize","tidy","unbloat"],"workflows":["ace-editor","approach-validator","archie","brave","ci-doctor","cloclo","craft","dev","grumpy-reviewer","mergefest","necromancer","pdf-summary","plan","poem-bot","pr-code-quality-reviewer","pr-nitpick-reviewer","scout","security-review","tidy","unbloat-docs"]}
# gh-aw-commands: {"payload_version":"v1","schema_version":"v1","compiler_version":"dev","commands":["ace","approach-validator","archie","brave","cloclo","craft","grumpy","matt","mergefest","nit","plan","poem-bot","review","scout","security-review","summarize","tidy","unbloat"],"workflows":["ace-editor","approach-validator","archie","brave","ci-doctor","cloclo","craft","dev","grumpy-reviewer","mattpocock-skills-reviewer","mergefest","necromancer","pdf-summary","plan","poem-bot","pr-code-quality-reviewer","pr-nitpick-reviewer","scout","security-review","tidy","unbloat-docs"]}
# Routing summary (sorted):
# slash commands:
# /ace -> ace-editor [pull_request_comment] reaction=eyes
Expand All @@ -8,6 +8,7 @@
# /cloclo -> cloclo [discussion,discussion_comment,issue_comment,issues,pull_request,pull_request_comment,pull_request_review_comment] reaction=eyes
# /craft -> craft [issues] reaction=eyes
# /grumpy -> grumpy-reviewer [pull_request_comment,pull_request_review_comment] reaction=eyes
# /matt -> mattpocock-skills-reviewer [issue_comment,pull_request_review_comment] reaction=eyes
# /mergefest -> mergefest [pull_request_comment] reaction=eyes
Comment on lines 9 to 12

Copilot AI May 19, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in f2f8717: the generated /matt route includes pull_request_comment, so normal PR conversation comments dispatch correctly.

# /nit -> pr-nitpick-reviewer [pull_request_comment,pull_request_review_comment] reaction=eyes
# /plan -> plan [discussion_comment,issue_comment] reaction=eyes
Expand All @@ -25,6 +26,8 @@
# dev -> dev [discussion,issues,pull_request] reaction=eyes
# necromancer -> necromancer [pull_request] reaction=eyes
# needs-design -> approach-validator [issues,pull_request] reaction=eyes
# pull-request reviewers:
# mattpocock-skills-reviewer [pull_request,pull_request_review]
# ___ _ _
# / _ \ | | (_)
# | |_| | __ _ ___ _ __ | |_ _ ___
Expand Down Expand Up @@ -55,7 +58,9 @@ on:
issue_comment:
types: [created, edited]
pull_request:
types: [edited, labeled, opened, reopened]
types: [edited, labeled, opened, ready_for_review, reopened, review_requested]
pull_request_review:
types: [submitted]
pull_request_review_comment:
types: [created, edited]
discussion:
Expand Down Expand Up @@ -87,8 +92,9 @@ jobs:
- name: Route slash command
uses: actions/github-script@3a2844b7e9c422d3c10d287c895573f7108da1b3 # v9.0.0
env:
GH_AW_SLASH_ROUTING: '{"ace":[{"workflow":"ace-editor","events":["pull_request_comment"],"ai_reaction":"eyes"}],"approach-validator":[{"workflow":"approach-validator","events":["issue_comment","pull_request_comment"],"ai_reaction":"eyes"}],"archie":[{"workflow":"archie","events":["issue_comment","issues","pull_request","pull_request_comment"],"ai_reaction":"eyes"}],"brave":[{"workflow":"brave","events":["issue_comment"],"ai_reaction":"eyes"}],"cloclo":[{"workflow":"cloclo","events":["discussion","discussion_comment","issue_comment","issues","pull_request","pull_request_comment","pull_request_review_comment"],"ai_reaction":"eyes"}],"craft":[{"workflow":"craft","events":["issues"],"ai_reaction":"eyes"}],"grumpy":[{"workflow":"grumpy-reviewer","events":["pull_request_comment","pull_request_review_comment"],"ai_reaction":"eyes"}],"mergefest":[{"workflow":"mergefest","events":["pull_request_comment"],"ai_reaction":"eyes"}],"nit":[{"workflow":"pr-nitpick-reviewer","events":["pull_request_comment","pull_request_review_comment"],"ai_reaction":"eyes"}],"plan":[{"workflow":"plan","events":["discussion_comment","issue_comment"],"ai_reaction":"eyes"}],"poem-bot":[{"workflow":"poem-bot","events":["issues"],"ai_reaction":"eyes"}],"review":[{"workflow":"pr-code-quality-reviewer","events":["pull_request_comment","pull_request_review_comment"],"ai_reaction":"eyes"}],"scout":[{"workflow":"scout","events":["discussion","discussion_comment","issue_comment","issues","pull_request","pull_request_comment","pull_request_review_comment"],"ai_reaction":"eyes"}],"security-review":[{"workflow":"security-review","events":["pull_request_comment","pull_request_review_comment"],"ai_reaction":"eyes"}],"summarize":[{"workflow":"pdf-summary","events":["issue_comment","issues"],"ai_reaction":"eyes"}],"tidy":[{"workflow":"tidy","events":["pull_request_comment"],"ai_reaction":"eyes"}],"unbloat":[{"workflow":"unbloat-docs","events":["pull_request_comment"],"ai_reaction":"eyes"}]}'
GH_AW_SLASH_ROUTING: '{"ace":[{"workflow":"ace-editor","events":["pull_request_comment"],"ai_reaction":"eyes"}],"approach-validator":[{"workflow":"approach-validator","events":["issue_comment","pull_request_comment"],"ai_reaction":"eyes"}],"archie":[{"workflow":"archie","events":["issue_comment","issues","pull_request","pull_request_comment"],"ai_reaction":"eyes"}],"brave":[{"workflow":"brave","events":["issue_comment"],"ai_reaction":"eyes"}],"cloclo":[{"workflow":"cloclo","events":["discussion","discussion_comment","issue_comment","issues","pull_request","pull_request_comment","pull_request_review_comment"],"ai_reaction":"eyes"}],"craft":[{"workflow":"craft","events":["issues"],"ai_reaction":"eyes"}],"grumpy":[{"workflow":"grumpy-reviewer","events":["pull_request_comment","pull_request_review_comment"],"ai_reaction":"eyes"}],"matt":[{"workflow":"mattpocock-skills-reviewer","events":["issue_comment","pull_request_review_comment"],"ai_reaction":"eyes"}],"mergefest":[{"workflow":"mergefest","events":["pull_request_comment"],"ai_reaction":"eyes"}],"nit":[{"workflow":"pr-nitpick-reviewer","events":["pull_request_comment","pull_request_review_comment"],"ai_reaction":"eyes"}],"plan":[{"workflow":"plan","events":["discussion_comment","issue_comment"],"ai_reaction":"eyes"}],"poem-bot":[{"workflow":"poem-bot","events":["issues"],"ai_reaction":"eyes"}],"review":[{"workflow":"pr-code-quality-reviewer","events":["pull_request_comment","pull_request_review_comment"],"ai_reaction":"eyes"}],"scout":[{"workflow":"scout","events":["discussion","discussion_comment","issue_comment","issues","pull_request","pull_request_comment","pull_request_review_comment"],"ai_reaction":"eyes"}],"security-review":[{"workflow":"security-review","events":["pull_request_comment","pull_request_review_comment"],"ai_reaction":"eyes"}],"summarize":[{"workflow":"pdf-summary","events":["issue_comment","issues"],"ai_reaction":"eyes"}],"tidy":[{"workflow":"tidy","events":["pull_request_comment"],"ai_reaction":"eyes"}],"unbloat":[{"workflow":"unbloat-docs","events":["pull_request_comment"],"ai_reaction":"eyes"}]}'
GH_AW_LABEL_ROUTING: '{"approach-proposal":[{"workflow":"approach-validator","events":["issues","pull_request"],"ai_reaction":"eyes"}],"ci-doctor":[{"workflow":"ci-doctor","events":["pull_request"],"ai_reaction":"eyes"}],"cloclo":[{"workflow":"cloclo","events":["discussion","issues","pull_request"],"ai_reaction":"eyes"}],"dev":[{"workflow":"dev","events":["discussion","issues","pull_request"],"ai_reaction":"eyes"}],"necromancer":[{"workflow":"necromancer","events":["pull_request"],"ai_reaction":"eyes"}],"needs-design":[{"workflow":"approach-validator","events":["issues","pull_request"],"ai_reaction":"eyes"}]}'
GH_AW_REVIEWER_ROUTING: '[{"workflow":"mattpocock-skills-reviewer","events":["pull_request","pull_request_review"]}]'
with:
script: |
const { setupGlobals } = require('${{ runner.temp }}/gh-aw/actions/setup_globals.cjs');
Expand Down
Loading
Loading