Skip to content

[security-fix] Security Fix: Unsafe Quoting in Import Directive Warning (Alert #8) #1523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 2 commits into from
Oct 11, 2025
Merged

[security-fix] Security Fix: Unsafe Quoting in Import Directive Warning (Alert #8) #1523

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d89ed75
Security Fix: Unsafe Quoting in Import Directive Warning (Alert #8)
github-actions[bot] Oct 11, 2025
74731da
Add changeset for security fix: unsafe quoting in import directive wa…
github-actions[bot] Oct 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions pkg/parser/frontmatter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -517,9 +517,15 @@ func processIncludesWithVisited(content, baseDir string, extractTools bool, visi
if directive != nil {
// Emit deprecation warning for legacy syntax
if directive.IsLegacy {
fmt.Fprintln(os.Stderr, console.FormatWarningMessage(fmt.Sprintf("Deprecated syntax: '%s'. Use '{{#import%s %s}}' instead.",
// Security: Escape strings to prevent quote injection in warning messages
// Use %q format specifier to safely quote strings containing special characters
optionalMarker := ""
if directive.IsOptional {
optionalMarker = "?"
}
fmt.Fprintln(os.Stderr, console.FormatWarningMessage(fmt.Sprintf("Deprecated syntax: %q. Use {{#import%s %s}} instead.",
directive.Original,
map[bool]string{true: "?", false: ""}[directive.IsOptional],
optionalMarker,
directive.Path)))
}

Expand Down