fix: propagate config fields to all layers - #8385
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟡 Changes recommended
The newly added mapping row introduces an internal contradiction with §14.1a by claiming enclaves[].dynamic is “not executable in this release” despite later runtime/prerequisite details describing how it runs when the compiler handoff is present.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates the AWF configuration specification to include the missing Section 5 CLI-mapping entry for the enclaves[].dynamic config field, closing a documentation gap identified by a recent config consistency audit.
Changes:
- Add a Section 5 “CLI mapping” table row for
enclaves[].dynamicindocs/awf-config-spec.md.
File summaries
| File | Description |
|---|---|
| docs/awf-config-spec.md | Adds the missing CLI-mapping row for enclaves[].dynamic in the config spec. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
✅ Copilot review passed with no inline comments. @github-actions[bot] Add the |
Documentation PreviewDocumentation has been built for this PR. To view locally:
Built from commit 9d0d491 |
|
@copilot address review feedback |
Addressed in |
|
@copilot rebase to main and resolve any merge conflicts |
…aves-dynamic-mapping-1789033170-b0b492d7a051f02a Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
Merged |
Summary
Config consistency audit of merged PRs from the last 7 days (#8074, #8119, #8196, #8217, #8276, #8292, #8305) found one gap:
enclaves[].dynamic(introduced by #8196/#8217 as the ADR-0001 dynamic repository-policy envelope) was present in the JSON schema, TypeScript types, and runtime validation/rejection logic, but missing from Section 5's CLI Mapping table indocs/awf-config-spec.md.Findings by PR
enclaves[].repos[].sensitivity: trustedenclaves[].agent.tools.github(+ deprecateagent.github.cli)docs/adr/0001-agent-enclaves.md(design doc only)enclaves[].dynamic(agent-only dynamic policy envelope)limits.timeoutSecondsunit clarified (seconds, not ns) — doc/description-onlysrc/awf-config-schema.jsonanddocs/awf-config.schema.jsonwere verified byte-identical (no drift).Fix
Added the missing row to Section 5 of
docs/awf-config-spec.md:Verification
npx tsc --noEmit— passesnpx jest src/schema.test.ts src/config-file*.test.ts src/enclave/preflight.test.ts src/parsers/enclave-parser.test.ts— 300/300 passeddiff src/awf-config-schema.json docs/awf-config.schema.json— identical