fix: support GPT-6 Astra model - #8147
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The new accounting test expects 0.7 credits, but the configured pricing produces 1.6.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Balanced
Findings: 1
New issues introduced by this change (1)
| Severity | Finding |
|---|---|
 |
containers/api-proxy/guards/ai-credits-guard.test.js — This assertion does not match the added pricing: 1,000 uncached input tokens at 10.00, 1,000 cached… |
What changed in this PR
Adds GPT-6 Astra support to Copilot model validation and AI-credit accounting.
Changes:
- Adds GPT-6 Astra to the supported model catalog.
- Adds curated pricing and validation/accounting coverage.
- Introduces an incorrect AI-credit test expectation.
| File | Description |
|---|---|
src/copilot-model.ts |
Registers GPT-6 Astra. |
src/copilot-model.test.ts |
Tests model validation. |
containers/api-proxy/ai-credits-pricing.js |
Adds curated pricing. |
containers/api-proxy/guards/ai-credits-guard.test.js |
Tests credit accounting. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| output_tokens: 100, | ||
| }, 'gpt-6-astra'); | ||
|
|
||
| expect(usage.aiCreditsThisResponse).toBeCloseTo(0.7, 10); |
✅ Coverage Check PassedOverall Coverage
📁 Per-file Coverage Changes (1 files)
Coverage comparison generated by |
lpcox
changed the title
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
✅ Copilot review passed with no inline comments. @lpcox Add the |
|
Build Test Failed Build Test Suite - See logs for details
|
|
🔌 Smoke Services — Service connectivity failed
|
|
🛡️ Smoke Copilot Network Isolation confirmed the egress allowlist is enforced. ✅ Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "example.com"See Network Configuration for more information.
|
|
❌ Smoke Gemini reports failed. Facets need polishing...
|
|
📡 Smoke OTel Tracing reports failed. OTel tracing regression detected.
|
|
❌ Contribution Check failed. Please review the logs for details.
|
|
📰 DEVELOPING STORY: Smoke Copilot reports failed. Our correspondents are investigating the incident...
|
|
❌ Smoke Copilot BYOK AOAI (api-key) reports failed. AOAI BYOK (api-key) mode investigation needed...
|
|
📰 DEVELOPING STORY: Smoke Docker Sbx reports failed. Our correspondents are investigating the incident...
|
|
Chroot tests passed! Smoke Chroot - All security and functionality tests succeeded.
|
|
🌑 The shadows whisper... Smoke Codex failed. The oracle requires further meditation...
|
|
✅ Security Guard completed successfully! Security review of PR #8147 complete. No security vulnerabilities found. The PR adds support for the GPT-6 Astra model by adding a pricing entry to ai-credits-pricing.js. This is a non-security-critical data file change with no firewall rule modifications, capability additions, validation weakening, or secrets exposure.
|
|
❌ Smoke Claude failed Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "api.anthropic.com"See Network Configuration for more information.
|
|
✅ Smoke Copilot BYOK AOAI (Entra) completed. Copilot AOAI BYOK (Entra) mode operational. 🔓
|
|
❌ Smoke Copilot BYOK reports failed. BYOK mode investigation needed...
|
This comment has been minimized.
This comment has been minimized.
|
✅ Smoke Copilot BYOK AOAI (api-key) completed. Copilot AOAI BYOK (api-key) mode operational. 🔓
|
|
✅ Contribution Check completed successfully! Code review complete for PR #8147. The PR description is clear, references the testing performed, and the changed files are placed in appropriate directories. No CONTRIBUTING.md issues found that require a comment.
|
|
✅ Build Test Suite completed successfully!
|
|
Chroot tests passed! Smoke Chroot - All security and functionality tests succeeded.
|
|
❌ Smoke Claude failed Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "api.anthropic.com"See Network Configuration for more information.
|
Smoke Test: Copilot BYOK (Direct) Mode ✅Test Results:
Status: PASS Running in direct BYOK mode (
|
|
@lpcox Network isolation egress smoke test results: EGRESS_RESULT allow=pass deny=pass ✅ Allowed domain (github.com) reachable: Overall: PASS Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "example.com"See Network Configuration for more information.
|
|
Smoke Test: Copilot Engine — @lpcox
Overall: PASS
|
|
@copilot address review feedback |
|
Smoke Test Results
Overall: FAIL —
|
Chroot Version Comparison Results
Overall: FAILED — Node.js version differs between host and chroot environments, so the
|
Running in direct BYOK mode (COPILOT_PROVIDER_API_KEY + COPILOT_PROVIDER_BASE_URL) via api-proxy → Azure OpenAI (Foundry, o4-mini-aw) Overall: FAIL
|
🏗️ Build Test Suite Results
Overall: 8/8 ecosystems passed — PASS Notes:
|
This was already addressed in eb186cb: the test expectation was corrected to 1.6 credits, matching the curated |
📡 OTel Tracing Smoke Test Results
Overall: ✅ All tracing integration points verified. No regressions detected.
|
|
@lpcox
|
Summary
Context
The generated model-to-API mapping added
gpt-6-astra, causing the catalog synchronization test to fail because AWF did not yet recognize the newly available Copilot CLI model.Testing
npm test(346 suites, 5528 tests passed)