Set runtime to docker-sbx in smoke-docker-sbx workflow frontmatter

.github/workflows/smoke-docker-sbx-build-test.md

@@ -47,6 +47,10 @@ safe-outputs:
     run-failure: "🐳🏗️ [{workflow_name}]({run_url}) reports {status}. Docker sbx build compatibility issue detected."
 timeout-minutes: 30
 sandbox:
+  agent:
+    id: awf
+    runtime: docker-sbx
+    sudo: true
   mcp:
     version: v0.3.32
 strict: false

.github/workflows/smoke-docker-sbx-claude.md

@@ -39,6 +39,10 @@ safe-outputs:
     run-failure: "🐳🟣 [{workflow_name}]({run_url}) reports {status}. Docker sbx + Claude compatibility issue detected."
 timeout-minutes: 15
 sandbox:
+  agent:
+    id: awf
+    runtime: docker-sbx
+    sudo: true
   mcp:
     version: v0.3.32
 strict: false

.github/workflows/smoke-docker-sbx-codex.md

@@ -39,6 +39,10 @@ safe-outputs:
     run-failure: "🐳🔮 [{workflow_name}]({run_url}) reports {status}. Docker sbx + Codex compatibility issue detected."
 timeout-minutes: 15
 sandbox:
+  agent:
+    id: awf
+    runtime: docker-sbx
+    sudo: true
   mcp:
     version: latest
 strict: false

.github/workflows/smoke-docker-sbx.md

@@ -41,6 +41,10 @@ safe-outputs:
     run-failure: "📰 DEVELOPING STORY: [{workflow_name}]({run_url}) reports {status}. Our correspondents are investigating the incident..."
 timeout-minutes: 15
 sandbox:
+  agent:
+    id: awf
+    runtime: docker-sbx
+    sudo: true
   mcp:
     version: v0.3.32
 strict: false

src/sbx-manager.test.ts

@@ -104,13 +104,12 @@ describe('sbx-manager', () => {
         process.env.HOME || '/home/runner',
       ], expect.objectContaining({
         input: 'y\n',
-        env: expect.objectContaining({
-          DOCKER_SANDBOXES_PROXY: 'http://172.30.0.10:3128',
-        }),
       }));
-      // XDG_CONFIG_HOME must not reach the sbx CLI
-      const sbxCreateCallEnv: Record<string, string | undefined> = mockExecaFn.mock.calls[1][2].env;
-      expect(sbxCreateCallEnv).not.toMatchObject({ XDG_CONFIG_HOME: expect.anything() });
+      // sbx create must NOT pass a custom env — it inherits process.env so the
+      // sbx CLI can find daemon credentials. The sandbox interior is isolated
+      // separately by execInSandbox() which uses sanitizeEnvForSbx().
+      const sbxCreateCall = mockExecaFn.mock.calls[1][2];
+      expect(sbxCreateCall.env).toBeUndefined();
     });
 
     it('uses SBX_DEFAULT_NAME when no name provided', async () => {
@@ -126,36 +125,31 @@ describe('sbx-manager', () => {
       expect(name).toBe(SBX_DEFAULT_NAME);
     });
 
-    it('uses default squidPort 3128 when not specified', async () => {
+    it('does not pass custom env during create (inherits process.env)', async () => {
       mockExecaFn
         .mockResolvedValueOnce({ exitCode: 0, stdout: '', stderr: '' })
         .mockResolvedValueOnce({ exitCode: 0, stdout: 'Created sandbox', stderr: '' });
 
       await createSandbox({ workspaceDir: '/ws', squidIp: '172.30.0.10' });
 
-      expect(mockExecaFn).toHaveBeenCalledWith(
-        'sbx',
-        expect.arrayContaining(['create']),
-        expect.objectContaining({
-          env: expect.objectContaining({ DOCKER_SANDBOXES_PROXY: 'http://172.30.0.10:3128' }),
-        }),
-      );
+      const sbxCreateCall = mockExecaFn.mock.calls[1][2];
+      expect(sbxCreateCall.env).toBeUndefined();
     });
 
-    it('uses custom squidPort when specified', async () => {
+    it('temporarily removes DOCKER_SANDBOXES_PROXY and XDG_CONFIG_HOME during create', async () => {
+      process.env.DOCKER_SANDBOXES_PROXY = 'http://old-proxy:3128';
+      process.env.XDG_CONFIG_HOME = '/home/runner';
       mockExecaFn
         .mockResolvedValueOnce({ exitCode: 0, stdout: '', stderr: '' })
         .mockResolvedValueOnce({ exitCode: 0, stdout: 'Created sandbox', stderr: '' });
 
       await createSandbox({ workspaceDir: '/ws', squidIp: '172.30.0.10', squidPort: 8080 });
 
-      expect(mockExecaFn).toHaveBeenCalledWith(
-        'sbx',
-        expect.arrayContaining(['create']),
-        expect.objectContaining({
-          env: expect.objectContaining({ DOCKER_SANDBOXES_PROXY: 'http://172.30.0.10:8080' }),
-        }),
-      );
+      // Both should be restored after create
+      expect(process.env.DOCKER_SANDBOXES_PROXY).toBe('http://old-proxy:3128');
+      expect(process.env.XDG_CONFIG_HOME).toBe('/home/runner');
+      delete process.env.DOCKER_SANDBOXES_PROXY;
+      delete process.env.XDG_CONFIG_HOME;
     });
 
     it('throws when auth check fails (non-zero exit)', async () => {

src/sbx-manager.ts

@@ -157,18 +157,39 @@ export async function createSandbox(config: SbxConfig): Promise<string> {
 
   logger.info(`[sbx] Running: sbx ${args.join(' ')}`);
 
-  const env = sanitizeEnvForSbx();
-  delete env.XDG_CONFIG_HOME;
-  env.DOCKER_SANDBOXES_PROXY = proxyUrl;
+  // Do NOT pass a custom `env` to sbx create. The sanitized env (which strips
+  // vars matching TOKEN, SECRET, KEY, etc.) also strips variables the sbx CLI
+  // needs internally for credential lookup against the daemon's auth store.
+  // Since sbx create is a management command that talks to the local daemon
+  // (not user code running inside the sandbox), inheriting process.env is safe —
+  // these env vars never enter the sandbox interior. The sandbox interior's env
+  // is controlled separately by execInSandbox() which uses sanitizeEnvForSbx().
+  //
+  // DOCKER_SANDBOXES_PROXY must NOT be set during create — it forces the daemon
+  // to route Docker Hub registry auth through Squid, which isn't ready yet.
+  // XDG_CONFIG_HOME must also be removed — the Copilot harness sets it to $HOME,
+  // which makes the sbx CLI look for credentials in $HOME/ instead of the
+  // default $HOME/.config/ where `sbx login` stored them.
+  const savedProxy = process.env.DOCKER_SANDBOXES_PROXY;
+  const savedXdg = process.env.XDG_CONFIG_HOME;
+  delete process.env.DOCKER_SANDBOXES_PROXY;
+  delete process.env.XDG_CONFIG_HOME;
 
   const createResult = await execa('sbx', args, {
-    env,
     input: 'y\n',
-    stdio: ['ignore', 'pipe', 'pipe'],
+    stdio: ['pipe', 'pipe', 'pipe'],
     reject: false,
     timeout: 120_000, // 2 minute timeout for sandbox creation
   });
 
+  // Restore env vars
+  if (savedProxy !== undefined) {
+    process.env.DOCKER_SANDBOXES_PROXY = savedProxy;
+  }
+  if (savedXdg !== undefined) {
+    process.env.XDG_CONFIG_HOME = savedXdg;
+  }
+
   const stdout = (createResult.stdout || '').trim();
   const stderr = (createResult.stderr || '').trim();
   const sbxSucceeded = stdout.includes('Created sandbox');