Skip to content

fix: propagate runner config fields to all layers #5716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lpcox merged 3 commits into from
Jun 30, 2026
+3 −0
Merged

fix: propagate runner config fields to all layers #5716

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4832872
fix: propagate runner config fields to spec
github-actions[bot] Jun 30, 2026
3efa742
Potential fix for pull request finding
lpcox Jun 30, 2026
bc3da11
docs: fix sysrootImage default registry description
Copilot Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions docs/awf-config-spec.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ following top-level properties. All are OPTIONAL:
| `container` | object | Container and Docker settings |
| `chroot` | object | Chroot execution overrides for split-filesystem ARC/DinD runners |
| `dind` | object | Bootstrap helpers for ARC/DinD split runner/daemon filesystems |
| `runner` | object | Runner topology declaration (standard vs. ARC/DinD) |
| `environment` | object | Environment variable propagation (see §8) |
| `logging` | object | Logging and diagnostics |
| `rateLimiting` | object | Egress rate limiting |
Expand Down Expand Up @@ -202,6 +203,8 @@ AWF settings MAY be supplied via config files, including stdin (`--config -`).
- `rateLimiting.requestsPerHour` → `--rate-limit-rph`
- `rateLimiting.bytesPerMinute` → `--rate-limit-bytes-pm`
- `platform.type` → *(config-only; maps to `AWF_PLATFORM_TYPE`)*
- `runner.topology` → *(config-only; sets runner deployment model — `standard` or `arc-dind`; activates sysroot staging, network isolation defaults, and tool cache validation when `arc-dind`)*
Comment thread
Copilot marked this conversation as resolved.
Outdated
- `runner.sysrootImage` → *(config-only; sysroot init-container image for `arc-dind` topology; defaults to `ghcr.io/github/gh-aw-firewall/build-tools:<imageTag>`)*

When `container.dockerHostPathPrefix` points at a daemon-visible shared `/tmp` path, the implementation stages the invoking CLI binary together with `/etc/passwd`, `/etc/group`, and the generated chroot `/etc/hosts` under that shared path so chroot mode can bootstrap on split-filesystem ARC/DinD hosts.

Expand Down