refactor(test): extract runAuditFilter helper to deduplicate audit filter tests by Copilot · Pull Request #5461 · github/gh-aw-firewall

Copilot · 2026-06-23T23:08:48Z

Four audit filter tests repeated identical setup/invoke/parse boilerplate, differing only in the filter option and assertion. Extracts a runAuditFilter helper that owns the common flow, letting each test express only what's unique.

Changes

src/commands/logs-audit.test.ts — adds runAuditFilter(options: Omit<AuditCommandOptions, 'format'>): Promise<any[]> inside the filtering describe block; refactors the four filter tests to use it

// Before — repeated in each of the four tests:
setupMocksWithMultipleEntries();
const options: AuditCommandOptions = { format: 'json', rule: 'deny-default' };
await auditCommand(options);
const output = mockConsoleLog.mock.calls[0][0] as string;
const parsed = JSON.parse(output);
expect(parsed).toHaveLength(1);
expect(parsed[0].domain).toBe('evil.com');

// After — helper owns the boilerplate:
async function runAuditFilter(options: Omit<AuditCommandOptions, 'format'>): Promise<any[]> {
  setupMocksWithMultipleEntries();
  await auditCommand({ format: 'json', ...options });
  const output = mockConsoleLog.mock.calls[0][0] as string;
  return JSON.parse(output);
}

it('should filter by rule ID', async () => {
  const parsed = await runAuditFilter({ rule: 'deny-default' });
  expect(parsed).toHaveLength(1);
  expect(parsed[0].domain).toBe('evil.com');
});

Copilot

Pull request overview

This PR refactors the logs-audit command unit tests to reduce duplicated setup/invoke/parse boilerplate in the “filtering” test cases by introducing a shared helper.

Changes:

Add a runAuditFilter(...) helper within the filtering describe block to encapsulate common test flow.
Refactor four filtering tests (rule/domain/decision allowed/decision denied) to use the helper.

Show a summary per file

File	Description
src/commands/logs-audit.test.ts	Extracts a helper to deduplicate repeated audit filtering test boilerplate and updates the relevant tests to use it.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Files reviewed: 1/1 changed files
Comments generated: 1

    }

-    it('should filter by rule ID', async () => {
+    async function runAuditFilter(options: Omit<AuditCommandOptions, 'format'>): Promise<any[]> {


lpcox · 2026-06-23T23:47:44Z

@copilot address review feedback

github-actions · 2026-06-23T23:48:22Z

✅ Copilot review passed with no inline comments.

@copilot Add the ready-for-aw label to this PR to trigger agentic CI smoke tests.

github-actions · 2026-06-23T23:49:51Z

✅ Coverage Check Passed

Overall Coverage

Metric	Base	PR	Delta
Lines	98.06%	98.10%	📈 +0.04%
Statements	98.00%	98.03%	📈 +0.03%
Functions	99.52%	99.52%	➡️ +0.00%
Branches	93.75%	93.78%	📈 +0.03%

📁 Per-file Coverage Changes (1 files)

File	Lines (Before → After)	Statements (Before → After)
`src/workdir-setup.ts`	92.7% → 94.5% (+1.82%)	92.7% → 94.5% (+1.82%)

Coverage comparison generated by scripts/ci/compare-coverage.ts

Copilot · 2026-06-23T23:51:22Z

@copilot address review feedback

Done in 66f48b2. Added a local AuditJsonEntry type that mirrors the shape produced by formatAuditJson(), changed runAuditFilter to return Promise<AuditJsonEntry[]>, and removed the (e: any) annotations in the .every() callbacks since the type is now inferred.

github-actions · 2026-06-23T23:57:28Z

🚀 Security Guard has started processing this pull request

github-actions · 2026-06-23T23:57:28Z

✅ Build Test Suite completed successfully!

github-actions · 2026-06-23T23:57:28Z

Chroot tests passed! Smoke Chroot - All security and functionality tests succeeded.

github-actions · 2026-06-23T23:57:29Z

✅ Smoke Copilot BYOK AOAI (Entra) completed. Copilot AOAI BYOK (Entra) mode operational. 🔓

github-actions · 2026-06-23T23:57:29Z

✅ Smoke Gemini completed. All facets verified. 💎

Smoke test in progress

github-actions · 2026-06-23T23:57:30Z

🔑 Smoke Copilot PAT PAT auth validated. All systems operational. ✅

github-actions · 2026-06-23T23:57:31Z

📡 Smoke OTel Tracing completed. All tracing scenarios validated. ✅

github-actions · 2026-06-23T23:57:31Z

📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤

github-actions · 2026-06-23T23:57:32Z

🔌 Smoke Services — All services reachable! ✅

github-actions · 2026-06-23T23:57:33Z

✅ Smoke Copilot BYOK AOAI (api-key) completed. Copilot AOAI BYOK (api-key) mode operational. 🔓

github-actions · 2026-06-23T23:57:38Z

✅ Contribution Check completed successfully!

Contribution guidelines review complete for PR #5461: no significant guideline issues found. The change is a test-only refactor, remains in the existing test file location, uses TypeScript types, does not add new functionality requiring new tests or docs, and has a clear PR description.

github-actions · 2026-06-23T23:57:39Z

✅ Smoke Claude passed

github-actions · 2026-06-23T23:57:45Z

✅ Smoke Copilot BYOK completed. Copilot BYOK mode operational. 🔓

github-actions · 2026-06-24T00:00:48Z

🔬 Smoke Test Results — PASS

Test	Result
GitHub MCP connectivity	✅
GitHub.com HTTP	✅ 200
File write/read	✅

PR: refactor(test): extract runAuditFilter helper to deduplicate audit filter tests
Author: @Copilot | Assignees: @lpcox @Copilot

Overall: ✅ PASS

📰 BREAKING: Report filed by Smoke Copilot

github-actions · 2026-06-24T00:01:09Z

Smoke Test: Copilot PAT Auth — FAIL

Test	Result
GitHub MCP	✅
HTTP (github.com)	❌ pre-step data missing
File write/read	❌ pre-step data missing

Overall: FAIL — template variables (${{ steps.smoke-data.outputs.* }}) were not substituted; pre-computed step outputs unavailable.

PR: "refactor(test): extract runAuditFilter helper to deduplicate audit filter tests" | Author: @Copilot | Assignees: @lpcox @Copilot
Auth mode: PAT (COPILOT_GITHUB_TOKEN)

🔑 PAT report filed by Smoke Copilot PAT

github-actions · 2026-06-24T00:01:30Z

Smoke Test: Claude Engine Validation

API status: ✅ PASS
GH check: ✅ PASS
File status: ✅ PASS

Overall result: PASS

Generated by Smoke Claude for issue #5461 · 61.1 AIC · ⊞ 3.1K · ◷

github-actions · 2026-06-24T00:01:39Z

Smoke Test: Copilot BYOK (Direct Mode) — PASS ✅

MCP connectivity: ✅ (gh-aw-firewall PRs listed)
GitHub.com connectivity: ✅
File write/read: ✅ (/tmp/gh-aw/agent/smoke-test-copilot-byok.txt)
BYOK inference path: ✅ (api-proxy → api.githubcopilot.com)

Running in direct BYOK mode (COPILOT_PROVIDER_API_KEY) via api-proxy sidecar.

🔑 BYOK report filed by Smoke Copilot BYOK

github-actions · 2026-06-24T00:01:42Z

Add Self-Hosted Runner Doctor workflow for ARC/DinD and enterprise AWF triage
Refactor api-proxy credential isolation into per-provider env builders
Checks: GitHub title ✅ | file write ✅ | discussion ✅ | build ✅
Overall: PASS

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

registry.npmjs.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "registry.npmjs.org"

See Network Configuration for more information.

🔮 The oracle has spoken through Smoke Codex

github-actions · 2026-06-24T00:02:12Z

🔭 Smoke Test: API Proxy OpenTelemetry Tracing

Scenario	Result	Notes
1. Module Loading	✅	`otel.js` loads cleanly; exports: `startRequestSpan`, `setTokenAttributes`, `setBudgetAttributes`, `endSpan`, `endSpanError`, `shutdown`, `isEnabled`
2. Test Suite	✅	59/59 tests pass across `otel.test.js` + `otel-fanout.test.js`
3. Env Var Forwarding	✅	`api-proxy-env-config.ts` forwards `GH_AW_OTLP_ENDPOINTS`, `OTEL_EXPORTER_OTLP_ENDPOINT`, `OTEL_EXPORTER_OTLP_HEADERS`, `GITHUB_AW_OTEL_TRACE_ID`, `GITHUB_AW_OTEL_PARENT_SPAN_ID`, `OTEL_SERVICE_NAME`
4. Token Tracker Integration	✅	`onUsage` callback present in `token-tracker-http.js` (lines 283, 324, 374)
5. OTEL Diagnostics	✅	Graceful degradation confirmed — no OTLP endpoint configured, falls back to `FileSpanExporter` → `/var/log/api-proxy/otel.jsonl`

All scenarios pass. ✅

📡 OTel tracing validated by Smoke OTel Tracing

github-actions · 2026-06-24T00:02:34Z

@Copilot @lpcox Smoke Test Results:

GitHub MCP connectivity: ✅
GitHub.com connectivity: ✅
File I/O test: ✅
BYOK inference test: ✅

Running in direct BYOK mode (COPILOT_PROVIDER_API_KEY + COPILOT_PROVIDER_BASE_URL) via api-proxy → Azure OpenAI (Foundry, o4-mini-aw)

Overall: PASS

🔑 BYOK (AOAI api-key) report filed by Smoke Copilot BYOK AOAI (api-key)

github-actions · 2026-06-24T00:02:52Z

Smoke Test Results

Check	Result
Redis PING	❌ timeout
PostgreSQL pg_isready	❌ no response
PostgreSQL SELECT 1	❌ timeout

Overall: FAIL — host.docker.internal (172.17.0.1) is unreachable on ports 6379 and 5432. Service containers may not be running or network access is blocked.

🔌 Service connectivity validated by Smoke Services

github-actions · 2026-06-24T00:02:58Z

Chroot Version Comparison Results

Runtime	Host Version	Chroot Version	Match?
Python	Python 3.12.13	Python 3.12.3	❌ No
Node.js	v24.16.0	v22.22.3	❌ No
Go	go1.22.12	go1.22.12	✅ Yes

Overall: ❌ Not all tests passed — Python and Node.js versions differ between host and chroot environments.

Tested by Smoke Chroot

github-actions · 2026-06-24T00:03:03Z

@lpcox @Copilot

GitHub MCP Testing: ✅
GitHub.com Connectivity: ✅
File Write/Read Test: ✅
BYOK Inference Test: ✅

Running in direct BYOK mode (AWF_AUTH_TYPE=github-oidc + AWF_AUTH_AZURE_* + COPILOT_PROVIDER_BASE_URL) via api-proxy → Azure OpenAI (Foundry, o4-mini-aw) authenticated via Microsoft Entra

Overall: PASS

🪪 BYOK (AOAI Entra) report filed by Smoke Copilot BYOK AOAI (Entra)

github-actions · 2026-06-24T00:08:34Z

Smoke Test Results (Gemini)

GitHub MCP Testing: ✅
- Refactor host-access validation tests to remove duplicated exit/assert scaffolding #5462: Refactor host-access validation tests to remove duplicated exit/assert scaffolding
- Add Self-Hosted Runner Doctor workflow for ARC/DinD and enterprise AWF triage #5460: Add Self-Hosted Runner Doctor workflow for ARC/DinD and enterprise AWF triage
GitHub.com Connectivity: ✅ (HTTP 200)
File Writing Testing: ✅
Bash Tool Testing: ✅

Overall status: PASS

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

localhost

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "localhost"

See Network Configuration for more information.

💎 Faceted by Smoke Gemini

github-actions · 2026-06-24T00:15:24Z

🏗️ Build Test Suite Results

Ecosystem	Project	Build/Install	Tests	Status
Bun	elysia	✅	1/1 passed	✅ PASS
Bun	hono	✅	1/1 passed	✅ PASS
C++	fmt	✅	N/A	✅ PASS
C++	json	✅	N/A	✅ PASS
Deno	oak	N/A	1/1 passed	✅ PASS
Deno	std	N/A	1/1 passed	✅ PASS
.NET	hello-world	✅	N/A	✅ PASS
.NET	json-parse	✅	N/A	✅ PASS
Go	color	✅	passed	✅ PASS
Go	env	✅	passed	✅ PASS
Go	uuid	✅	passed	✅ PASS
Java	gson	✅	1/1 passed	✅ PASS
Java	caffeine	✅	1/1 passed	✅ PASS
Node.js	clsx	✅	All passed	✅ PASS
Node.js	execa	✅	All passed	✅ PASS
Node.js	p-limit	✅	All passed	✅ PASS
Rust	fd	✅	1/1 passed	✅ PASS
Rust	zoxide	✅	1/1 passed	✅ PASS

Overall: 8/8 ecosystems passed — ✅ PASS

Generated by Build Test Suite for issue #5461 · 52.5 AIC · ⊞ 7.7K · ◷

Initial plan

dcd1364

Copilot AI assigned Copilot and lpcox Jun 23, 2026

Copilot started work on behalf of lpcox June 23, 2026 23:08 View session

refactor: extract runAuditFilter helper in audit filter tests

856348a

Copilot AI changed the title ~~[WIP] Refactor duplicate code in audit command filtering tests~~ refactor(test): extract runAuditFilter helper to deduplicate audit filter tests Jun 23, 2026

Copilot AI requested a review from lpcox June 23, 2026 23:11

Copilot finished work on behalf of lpcox June 23, 2026 23:11

lpcox marked this pull request as ready for review June 23, 2026 23:44

Copilot AI review requested due to automatic review settings June 23, 2026 23:44

Copilot started reviewing on behalf of lpcox June 23, 2026 23:44 View session

Copilot AI reviewed Jun 23, 2026

View reviewed changes

Comment thread src/commands/logs-audit.test.ts Outdated

}

it('should filter by rule ID', async () => {

async function runAuditFilter(options: Omit<AuditCommandOptions, 'format'>): Promise<any[]> {

Copilot started work on behalf of lpcox June 23, 2026 23:48 View session

refactor(test): use typed AuditJsonEntry in runAuditFilter

66f48b2

Copilot finished work on behalf of lpcox June 23, 2026 23:51

lpcox added the ready-for-aw label Jun 23, 2026

github-actions Bot added the smoke-copilot label Jun 24, 2026

github-actions Bot mentioned this pull request Jun 24, 2026

[aw] No-Op Runs #5368

Closed

github-actions Bot added the smoke-claude label Jun 24, 2026

github-actions Bot added the smoke-copilot-byok label Jun 24, 2026

github-actions Bot added the smoke-codex label Jun 24, 2026

lpcox temporarily deployed to aoai-model June 24, 2026 00:02 — with GitHub Actions Inactive

github-actions Bot added the smoke-copilot-byok-aoai-apikey label Jun 24, 2026

This comment has been minimized.

Sign in to view

github-actions Bot added the build-test label Jun 24, 2026

github-actions Bot added the smoke-copilot-byok-aoai-entra label Jun 24, 2026

lpcox temporarily deployed to aoai-model June 24, 2026 00:03 — with GitHub Actions Inactive

github-actions Bot mentioned this pull request Jun 24, 2026

[aw] Build Test Suite failed #5466

Closed

github-actions Bot added the smoke-gemini label Jun 24, 2026

lpcox merged commit 39abc55 into main Jun 24, 2026
90 of 92 checks passed

lpcox deleted the copilot/audit-command-filtering-duplication branch June 24, 2026 00:20

Uh oh!

Conversation

Copilot AI commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Copilot's findings

Uh oh!

lpcox commented Jun 23, 2026

Uh oh!

github-actions Bot commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 23, 2026

✅ Coverage Check Passed

Overall Coverage

Uh oh!

Copilot AI commented Jun 23, 2026

Uh oh!

github-actions Bot commented Jun 23, 2026

Uh oh!

github-actions Bot commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 24, 2026

🔬 Smoke Test Results — PASS

Uh oh!

github-actions Bot commented Jun 24, 2026

Smoke Test: Copilot PAT Auth — FAIL

Uh oh!

github-actions Bot commented Jun 24, 2026

Smoke Test: Claude Engine Validation

Uh oh!

github-actions Bot commented Jun 24, 2026

Uh oh!

github-actions Bot commented Jun 24, 2026

Uh oh!

github-actions Bot commented Jun 24, 2026

🔭 Smoke Test: API Proxy OpenTelemetry Tracing

Uh oh!

github-actions Bot commented Jun 24, 2026

Uh oh!

github-actions Bot commented Jun 24, 2026

Smoke Test Results

Copilot AI commented Jun 23, 2026 •

edited

Loading

github-actions Bot commented Jun 23, 2026 •

edited

Loading

github-actions Bot commented Jun 23, 2026 •

edited

Loading

github-actions Bot commented Jun 23, 2026 •

edited

Loading

github-actions Bot commented Jun 23, 2026 •

edited

Loading

github-actions Bot commented Jun 23, 2026 •

edited

Loading

github-actions Bot commented Jun 23, 2026 •

edited

Loading

github-actions Bot commented Jun 23, 2026 •

edited

Loading

github-actions Bot commented Jun 23, 2026 •

edited

Loading

github-actions Bot commented Jun 23, 2026 •

edited

Loading

github-actions Bot commented Jun 23, 2026 •

edited

Loading

github-actions Bot commented Jun 23, 2026 •

edited

Loading

github-actions Bot commented Jun 23, 2026 •

edited

Loading

github-actions Bot commented Jun 23, 2026 •

edited

Loading