Skip to content

refactor(test): deduplicate TLS tunnel mock setup in websocket tests #4330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lpcox merged 1 commit into from
Jun 4, 2026
Merged

refactor(test): deduplicate TLS tunnel mock setup in websocket tests #4330

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 11 additions & 48 deletions containers/api-proxy/server.websocket.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ describe('proxyWebSocket', () => {

describe('CONNECT tunnel and auth injection', () => {
let wsProxy;
let socket, connectReq, tunnel, tlsSocket;

beforeAll(() => {
// Re-require server with HTTPS_PROXY so proxyWebSocket uses the proxy URL.
Expand All @@ -119,12 +120,18 @@ describe('proxyWebSocket', () => {
jest.resetModules();
});

it('returns 502 when the CONNECT response is not 200', () => {
const socket = makeMockSocket();
const connectReq = new EventEmitter();
beforeEach(() => {
socket = makeMockSocket();
connectReq = new EventEmitter();
connectReq.end = jest.fn();
const tunnel = makeMockSocket();
tunnel = makeMockSocket();
tlsSocket = new EventEmitter();
tlsSocket.write = jest.fn();
tlsSocket.destroy = jest.fn();
tlsSocket.pipe = jest.fn();
});

it('returns 502 when the CONNECT response is not 200', () => {
jest.spyOn(http, 'request').mockReturnValue(connectReq);
setImmediate(() => connectReq.emit('connect', { statusCode: 407 }, tunnel));

Expand All @@ -139,10 +146,6 @@ describe('proxyWebSocket', () => {
});

it('returns 502 when the CONNECT request emits an error', () => {
const socket = makeMockSocket();
const connectReq = new EventEmitter();
connectReq.end = jest.fn();

jest.spyOn(http, 'request').mockReturnValue(connectReq);
setImmediate(() => connectReq.emit('error', new Error('connection refused')));

Expand All @@ -156,15 +159,6 @@ describe('proxyWebSocket', () => {
});

it('returns 502 when TLS handshake fails', () => {
const socket = makeMockSocket();
const connectReq = new EventEmitter();
connectReq.end = jest.fn();
const tunnel = makeMockSocket();
const tlsSocket = new EventEmitter();
tlsSocket.write = jest.fn();
tlsSocket.destroy = jest.fn();
tlsSocket.pipe = jest.fn();

jest.spyOn(http, 'request').mockReturnValue(connectReq);
jest.spyOn(tls, 'connect').mockReturnValue(tlsSocket);

Expand All @@ -185,15 +179,6 @@ describe('proxyWebSocket', () => {
});

it('injects Authorization header and fixes Host header in the upgrade request', () => {
const socket = makeMockSocket();
const connectReq = new EventEmitter();
connectReq.end = jest.fn();
const tunnel = makeMockSocket();
const tlsSocket = new EventEmitter();
tlsSocket.write = jest.fn();
tlsSocket.destroy = jest.fn();
tlsSocket.pipe = jest.fn();

jest.spyOn(http, 'request').mockReturnValue(connectReq);
jest.spyOn(tls, 'connect').mockReturnValue(tlsSocket);

Expand Down Expand Up @@ -221,15 +206,6 @@ describe('proxyWebSocket', () => {
});

it('strips client-supplied auth headers before forwarding', () => {
const socket = makeMockSocket();
const connectReq = new EventEmitter();
connectReq.end = jest.fn();
const tunnel = makeMockSocket();
const tlsSocket = new EventEmitter();
tlsSocket.write = jest.fn();
tlsSocket.destroy = jest.fn();
tlsSocket.pipe = jest.fn();

jest.spyOn(http, 'request').mockReturnValue(connectReq);
jest.spyOn(tls, 'connect').mockReturnValue(tlsSocket);

Expand Down Expand Up @@ -264,10 +240,6 @@ describe('proxyWebSocket', () => {
});

it('forwards the CONNECT request to the configured Squid proxy host/port', () => {
const socket = makeMockSocket();
const connectReq = new EventEmitter();
connectReq.end = jest.fn();

let capturedOptions;
jest.spyOn(http, 'request').mockImplementation((options) => {
capturedOptions = options;
Expand All @@ -284,15 +256,6 @@ describe('proxyWebSocket', () => {
});

it('forwards buffered head bytes to the upstream after upgrade', () => {
const socket = makeMockSocket();
const connectReq = new EventEmitter();
connectReq.end = jest.fn();
const tunnel = makeMockSocket();
const tlsSocket = new EventEmitter();
tlsSocket.write = jest.fn();
tlsSocket.destroy = jest.fn();
tlsSocket.pipe = jest.fn();

jest.spyOn(http, 'request').mockReturnValue(connectReq);
jest.spyOn(tls, 'connect').mockReturnValue(tlsSocket);

Expand Down
Loading