Skip to content

fix: add explicit execute directive to smoke-codex to prevent noop #1078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lpcox merged 2 commits into from
Feb 27, 2026
Merged

fix: add explicit execute directive to smoke-codex to prevent noop #1078

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d59a60f
Initial plan
Copilot Feb 27, 2026
ddbfabe
fix: add explicit execute directive to smoke-codex to prevent noop
Copilot Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/smoke-codex.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,8 @@ post-steps:
echo "Safe output validation passed"
---

> **⚡ EXECUTE NOW:** Run all steps 1–8 below and call `add_comment` on this pull request with results. This is a mandatory smoke test execution—not documentation to read.

Copilot AI Feb 27, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This directive unconditionally tells the agent to call add_comment “on this pull request”, but this workflow also runs on schedule and workflow_dispatch where there may be no PR context. Consider making the instruction conditional (e.g., only require add_comment when ${{ github.event_name }} is pull_request), aligning with the post-step validation that only enforces add_comment for PR triggers.

Copilot uses AI. Check for mistakes.

# Smoke Test: Codex Engine Validation

**IMPORTANT: Keep all outputs extremely short and concise. Use single-line responses where possible. No verbose explanations.**
Expand Down