Don't interpret signature delimiter in the middle of line as signature

[anaulin]

This fixes the problem described in issue #17

[anaulin]

@technoweenie could you have a look at this?

[anaulin]

@defunkt could you or someone else on your team have a look at this PR?

[technoweenie]

Hi, thanks for the patch. I've filed an internal issue for someone to look at. Do you want me cut a pre-release gem for you?

[anaulin]

No need for a pre-release gem, thanks (I'm running a rudely monkey-patched version).

[anaulin]

Any chance this will ever get reviewed? Or should I just close this PR?

[technoweenie]

Nope, this slipped through the cracks. I'll just merge it.

[technoweenie]

  2) Failure:
test_reads_email_with_correct_signature(EmailReplyParserTest) [/Users/rick/p/email_reply_parser/test/email_reply_parser_test.rb:87]:
Expected /^-- \nrick/ to match "--\nrick\n".

  3) Failure:
test_reads_simple_body(EmailReplyParserTest) [/Users/rick/p/email_reply_parser/test/email_reply_parser_test.rb:14]:
<3> expected but was
<2>.

  4) Failure:
test_reads_top_post(EmailReplyParserTest) [/Users/rick/p/email_reply_parser/test/email_reply_parser_test.rb:33]:
<5> expected but was
<4>.

Failures ^

[technoweenie]

Fix in 7837dac. The regexes are backwards because of the way it figures out which fragments to show on emails with inline replies. Take the following email for example:

> 1: Hi

2. Sup

> 3: Bye!

We want fragment 3 to be hidden. Fragment 1 should be shown, because it's necessary context for fragment 2. If we parse top to bottom, we have no idea if fragment 1 should be hidden or not. By parsing from bottom to top, we mark replied fragments hidden until an original fragment (like 2) is found.

[anaulin]

Thanks for fixing that, and for merging in. Ok with you if I delete this branch? Or do you guys like to keep those around?

[anaulin]

Also, any idea when you'll have a new release with this fix?

[technoweenie]

Just pushed it to rubygems. https://github.com/github/email_reply_parser/releases/tag/v0.5.6

Feel free to delete the branch. GitHub PRs are Git refs, so we can easily restore them if we really need to.

Thanks for the patch!

[anaulin]

Awesome, thanks for the review and the release!