Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update managing-complex-workflows.md #762

Merged
merged 3 commits into from
Nov 4, 2020
Merged

Conversation

gsrohde
Copy link
Contributor

@gsrohde gsrohde commented Oct 23, 2020

Environment variable names are apparently case-sensitive since without this change, the example-command (I tried it with echo) is fed the empty string. (On the other hand, environment variable names are case-insensitive in one respect: Trying to define two environment variables whose names differ only in case yields a "duplicate definition" error.) This relates to issue #761.

Why:

The example does not work as expected.

What's being changed:

Check off the following:

Environment variable names are apparently case-sensitive since without this change, the `example-command` (I tried it with `echo`) is fed the empty string.  (On the other hand, environment variable names are case-_insensitive_ in one respect: Trying to define two environment variables whose names differ only in case yields a "duplicate definition" error.)
@welcome
Copy link

welcome bot commented Oct 23, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilene
Copy link
Contributor

Thanks for opening a PR @gsrohde! I'll get this triaged for review 🌟

@janiceilene janiceilene added actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! labels Oct 23, 2020
@lucascosti lucascosti self-assigned this Nov 4, 2020
@lucascosti
Copy link
Contributor

Thanks a lot for this, @gsrohde! You are correct for most *nix OSs, but it might depend on the OS and shell of the runner executing the job.

This example doesn't specify a runs-on: key so it's ambiguous. I'll add a slight edit to your PR to add the key with an ubuntu-latest runner so it's correct for Linux runners (by far the most popular OS in Actions) and it shows the case of the environment variable should be the same.

@lucascosti lucascosti merged commit b28bf10 into github:main Nov 4, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2020

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Secrets example in Managing complex workflows doesn't work as expected
3 participants