-
Notifications
You must be signed in to change notification settings - Fork 60.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Code security
feature descriptions
#35327
Conversation
NOTE: There are still muliple occurrences of the text "code security and analysis" (mostly in the metadata), but I was unsure if to change them accordingly. |
a05c2f0
to
481d068
Compare
481d068
to
6b7019d
Compare
Hi @akordowski 👋 this turned out to be simpler than I initially thought. It transpires that all current GHES versions still use the "Code security and analysis" wording, but Dotcom (FPT and GHEC) versions use the new wording. With that said, I'd be happy to accept this PR if the conflicts are fixed and versioning is applied appropriately. Before I fixed it myself internally, I wanted to give you that option. The best way to handle versioning in this case would be to create a feature-based versioning file versioned for Let me know what you think—if you'd prefer not to do this, just let me know and I'll fix it internally and add you as co-committer. Many thanks! |
Hi @subatoi 👋
I am not familiar with the porcess how to do it, so I would leave it up to you. As there are a lot of occurrences of If the versoning is done I could help you with the replacement. Let me know. |
No problem @akordowski — I'll handle this internally 👍
We could certainly use a reusable if the language were the same, yes. For the moment, I'll handle the replacement without using a reusable, but we can revisit that idea afterwards (I'll come back to you when it's merged, though it's possible it won't be this week as we're going on a soft freeze for the US Thanksgiving week). In the meantime I'm afraid we'll have to close this PR, but thank you again for your help! I'm still happy to add you as a co-committer, since this branch will be useful as a starting point for me. |
No problem, if you need any help with the other changes feel free to reach out. |
Why:
Fix and unify the
Code security
feature description matching the current descriptions in the GitHub menu.Closes: #35325
What's being changed (if available, include any code snippets, screenshots, or gifs):
Check off the following:
I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).
data
directory.For content changes, I have completed the self-review checklist.